Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: overwrite timeout commit from 1.5s to 1s #8298

Merged
merged 2 commits into from
May 23, 2024

Conversation

PaddyMc
Copy link
Contributor

@PaddyMc PaddyMc commented May 23, 2024

What is the purpose of the change

Overwrites timeout commit from 1.5s to 1s.

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

Version v25.0.1 brings significant enhancements to the Osmosis and CometBFT modules. Notable changes include upgrading to IBC v7.4.1, implementing caching, updating dependencies, and optimizing performance in sendManyPackets. These modifications aim to improve efficiency and functionality within the project.

Changes

File Change Summary
Osmosis Upgraded to IBC v7.4.1, implemented caching, updated dependencies
CometBFT Refactored sendManyPackets for performance, removed call from LoadBlock

🐰
In modules tweaked, in code so sleek,
Upgrades applied, efficiency we seek.
IBC elevated, caching embraced,
Performance refined, old bits erased.

🚀🛠️


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fd9960a and e6b52e4.
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional Context Used
Markdownlint (9)
CHANGELOG.md (9)

1043: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time


1055: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time


1064: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time


1069: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time


1121: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time


382: Punctuation: '.'
Trailing punctuation in heading


645: null
Bare URL used


703: null
Bare URL used


1284: null
No empty links

Additional comments not posted (1)
CHANGELOG.md (1)

51-60: Ensure the changelog entry for the timeout commit change is accurate.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PaddyMc PaddyMc added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels May 23, 2024
@PaddyMc PaddyMc merged commit b51b946 into main May 23, 2024
1 check passed
@PaddyMc PaddyMc deleted the chore/overwrite-timout-commit-reduction-half-second branch May 23, 2024 15:03
mergify bot pushed a commit that referenced this pull request May 23, 2024
* chore: overwrite timeout commit from 1.5s to 1s

* chore: update CHANGELOG.md

(cherry picked from commit b51b946)

# Conflicts:
#	CHANGELOG.md
PaddyMc added a commit that referenced this pull request May 23, 2024
* chore: overwrite timeout commit from 1.5s to 1s (#8298)

* chore: overwrite timeout commit from 1.5s to 1s

* chore: update CHANGELOG.md

(cherry picked from commit b51b946)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: PaddyMc <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v25.x backport patches to v25.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants