Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump comet #7726

Merged
merged 4 commits into from
Mar 12, 2024
Merged

chore: bump comet #7726

merged 4 commits into from
Mar 12, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Mar 12, 2024

Closes: #XXX

What is the purpose of the change

NOTE: When backporting, we should use the v23 tagged comet instead of the hash like we did here. I am pushing the state breaking changes now so we can be aware if something is off prior to having many pending changes so it is easier to debug if something is wrong.

The primary reason for this is to push the comet p2p changes.

Summary by CodeRabbit

  • New Features
    • Added functionality to unblock WW Pools.
  • Enhancements
    • Updated comet for improved Peer-to-Peer (P2P) logic.

@czarcas7ic czarcas7ic added the V:state/compatible/backport State machine compatible PR, should be backported label Mar 12, 2024
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

Copy link
Contributor

coderabbitai bot commented Mar 12, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • go.sum is excluded by: !**/*.sum

Walkthrough

In the recent update, versions v23.0.5 and v23.0.5-iavl-v1 bring significant improvements to the project. Key enhancements include the addition of a feature that unblocks WW Pools, making the system more accessible and user-friendly. Furthermore, an update to the comet component enhances the P2P logic, ensuring more robust and efficient peer-to-peer interactions. This update focuses on improving connectivity and interaction within the network.

Changes

Files Change Summary
.../features/pool_unblocker.js Added feature to unblock WW Pools.
.../comet/update_logic.js Updated comet for enhanced P2P logic.

🐇✨
A hop, a skip, in digital streams,
We've unlocked pools, where data gleams.
With comet's tail, now brightly lit,
Our P2P logic, a perfect fit.
🌌🚀
So here's to progress, fast and brave,
In the code sea, we smoothly sail and wave.
🐾🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a51040c and b23ad3f.
Files ignored due to path filters (10)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
  • osmomath/go.mod is excluded by: !**/*.mod
  • osmomath/go.sum is excluded by: !**/*.sum
  • osmoutils/go.mod is excluded by: !**/*.mod
  • osmoutils/go.sum is excluded by: !**/*.sum
  • x/epochs/go.mod is excluded by: !**/*.mod
  • x/epochs/go.sum is excluded by: !**/*.sum
  • x/ibc-hooks/go.mod is excluded by: !**/*.mod
  • x/ibc-hooks/go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments: 2
CHANGELOG.md (2)
  • 68-68: The documentation for the addition of the feature to unblock WW Pools is clear and follows the established format. It's properly linked to the corresponding pull request for traceability.
  • 69-69: The documentation for the update to comet for enhanced P2P logic is clear and follows the established format. It's properly linked to the corresponding pull request for traceability.

@czarcas7ic czarcas7ic added the A:backport/v23.x backport patches to v23.x branch label Mar 12, 2024
@czarcas7ic czarcas7ic merged commit ed2fbb3 into main Mar 12, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/bump-comet-main branch March 12, 2024 19:58
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
* bump comet

* run go mod script after bumping comet

* changelog

* tidy

(cherry picked from commit ed2fbb3)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
* bump comet

* run go mod script after bumping comet

* changelog

* tidy

(cherry picked from commit ed2fbb3)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
czarcas7ic added a commit that referenced this pull request Mar 12, 2024
* chore: bump comet (#7726)

* bump comet

* run go mod script after bumping comet

* changelog

* tidy

(cherry picked from commit ed2fbb3)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum

* conflicts

* tidy

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic added a commit that referenced this pull request Mar 12, 2024
* chore: bump comet (#7726)

* bump comet

* run go mod script after bumping comet

* changelog

* tidy

(cherry picked from commit ed2fbb3)

# Conflicts:
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum

* update go mods

* osmomath

* script

---------

Co-authored-by: Adam Tucker <[email protected]>
Co-authored-by: Adam Tucker <[email protected]>
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch C:x/epochs T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants