Speedup CL: TickToPrice #7539
Merged
Speedup CL: TickToPrice #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
ValarDragon
requested review from
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
mattverse
approved these changes
Feb 19, 2024
| @@ -8,6 +8,8 @@ import ( | |||
| "github.com/osmosis-labs/osmosis/v23/x/concentrated-liquidity/types" | |||
| ) | |||
|
|
|||
| var maxSpotPriceBigDec = osmomath.BigDecFromDec(types.MaxSpotPrice) | |||
There was a problem hiding this comment.
nit: let's move this to types
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Speedup CL: TickToPrice * Speedup PriceToTick * Address Matt's comment (cherry picked from commit a80c00e)
mergify bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
* Speedup CL: TickToPrice * Speedup PriceToTick * Address Matt's comment (cherry picked from commit a80c00e)
ValarDragon
added a commit
that referenced
this pull request
Feb 19, 2024
* Speedup CL: TickToPrice * Speedup PriceToTick * Address Matt's comment (cherry picked from commit a80c00e) Co-authored-by: Dev Ojha <[email protected]>
ValarDragon
added a commit
that referenced
this pull request
Feb 20, 2024
* Speedup CL: TickToPrice * Speedup PriceToTick * Address Matt's comment (cherry picked from commit a80c00e) Co-authored-by: Dev Ojha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick speedups to CL's TickToPrice and PriceToTick. We need to update the osmomath version to get the more significant speedups in backports.