fix: Add Err handling for ABCI Query Route for wasm binded query #6886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
mergify bot
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Add err handle * ADd changelog (cherry picked from commit f11259d)
mattverse
added a commit
that referenced
this pull request
Dec 1, 2023
…) (#6970) * Add err handle * ADd changelog (cherry picked from commit f11259d) Co-authored-by: Matt, Park <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
From {unknown}{unknown} reasons, ABCI Query Route would return value of nil without erroring. (Mostly due to how we handle concurrent handling in ABCI Query, but need more investigation on this)
Due to the reasons above, we would get a panic in our nodes, since we're trying to access a nil value.
This PR eases the panicking behaviour, catching if the value is nil beforeahand.
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)