Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Silence usage to rootCmd #686

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

mattverse
Copy link
Member

Closes: #668

Description

This PR sets SilenceUsage to true when creating a root command for osmosis so that RPC errors for queries and txs do not omit all the help usage commands when facing an error.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #686 (448f698) into main (b03cc8c) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
- Coverage   18.39%   18.14%   -0.25%     
==========================================
  Files         173      179       +6     
  Lines       24321    24453     +132     
==========================================
- Hits         4473     4437      -36     
- Misses      19086    19257     +171     
+ Partials      762      759       -3     
Impacted Files Coverage Δ
x/gamm/types/pool.go 0.00% <0.00%> (-69.32%) ⬇️
x/gamm/types/pool_asset.go 0.00% <0.00%> (-68.52%) ⬇️
x/gamm/types/msgs.go 71.42% <0.00%> (-10.66%) ⬇️
x/incentives/keeper/gauge.go 54.68% <0.00%> (-9.94%) ⬇️
x/gamm/types/codec.go 40.74% <0.00%> (-1.20%) ⬇️
x/gamm/keeper/pool.go 81.08% <0.00%> (ø)
x/gamm/client/cli/tx.go 65.53% <0.00%> (ø)
x/gamm/keeper/pool_service.go 62.35% <0.00%> (ø)
x/gamm/types/marshal.go
x/gamm/types/balancerPool.pb.go
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03cc8c...448f698. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Can you add a changelog entry

@mattverse
Copy link
Member Author

Sure, and as mentioned, only tested in local environment.

@ValarDragon ValarDragon merged commit 1ac2c10 into main Dec 22, 2021
@ValarDragon ValarDragon deleted the mattverse/suppress-usage-guide branch December 22, 2021 21:11
ValarDragon pushed a commit that referenced this pull request Jan 1, 2022
* Add Silence usage to rootCmd

* Add changelog
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CLI: Suppress usage guide when tx or query has an error
3 participants