feat: improve set-env CLI cmd #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
|
@devbot-wizard help |
|
Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:
|
|
devbot add changelog misc |
ValarDragon
approved these changes
Aug 9, 2023
czarcas7ic
added
V:state/compatible/no_backport
p0mvn
pushed a commit
that referenced
this pull request
Aug 29, 2023
* improve set-env CLI cmd * update changelog * add optional chain id to localnet --------- Co-authored-by: devbot-wizard <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Screen.Recording.2023-08-08.at.6.24.17.PM.mov
Getting started with osmosis is not very user friendly. The set-env command was a step in the right direction, but it still doesn't feel useable out of the box.
With this PR, a user can go from having no .osmosisd folder to querying the chain with a single command.
Additionally, it fills out the chain-id in the client.toml, so the only flag a user should have to pass in is gas flags (you could 100 percent add this as well, but I wasn't quite sure what default gas values should be used).
Edit: last minute addition, allows you to add a chain ID to the set-env for localnet. If no chainID for localnet is provided, it default to localosmosis chain ID.
Testing and Verifying
Tested against mainnet, testnet, and local env.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)