refactor(CL): replace 6 return values in CreatePosition with a struct #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devbot add changelog api replace 6 return values in CL CreatePosition with a struct |
p0mvn
added
the
V:state/compatible/backport
|
devbot add changelog misc allow testing with different chain-id's in E2E testing |
|
Test failure here is coming from |
|
devbot add changelog misc allow testing with different chain-id's in E2E testing |
|
devbot add changelog api replace 6 return values in CL CreatePosition with a struct |
ValarDragon
reviewed
Aug 8, 2023
ValarDragon
reviewed
Aug 8, 2023
ValarDragon
reviewed
Aug 8, 2023
ValarDragon
approved these changes
Aug 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
…#5983) * refactor(CL): replace 6 return values in CreatePosition with a struct * changelog * update changelog * update changelog * Apply suggestions from code review * Update x/concentrated-liquidity/lp.go --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: Dev Ojha <[email protected]> (cherry picked from commit 86f0c00) # Conflicts: # CHANGELOG.md # x/concentrated-liquidity/lp.go # x/concentrated-liquidity/msg_server.go # x/concentrated-liquidity/position.go # x/concentrated-liquidity/position_test.go # x/concentrated-liquidity/swaps_test.go
p0mvn
added a commit
that referenced
this pull request
Aug 9, 2023
ValarDragon
pushed a commit
that referenced
this pull request
Aug 9, 2023
… (backport #5983) (#5988) Co-authored-by: Roman <[email protected]>
p0mvn
added a commit
that referenced
this pull request
Aug 29, 2023
…#5983) * refactor(CL): replace 6 return values in CreatePosition with a struct * changelog * update changelog * update changelog * Apply suggestions from code review * Update x/concentrated-liquidity/lp.go --------- Co-authored-by: devbot-wizard <[email protected]> Co-authored-by: Dev Ojha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
CreatePositionhas too many return values. This PR refactors 6 of them with a struct.A separate struct is created (instead of using
model.Positionor similar) so that all fields of the returned struct are guaranteed to be set without redundancy with respect to the input values.Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)