Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix CreateGauge CLI and add gas cost to create gauge #5511

Merged
merged 4 commits into from
Jun 17, 2023
Merged

[fix] Fix CreateGauge CLI and add gas cost to create gauge #5511

merged 4 commits into from
Jun 17, 2023

Conversation

stackman27
Copy link
Contributor

Closes: #XXX

What is the purpose of the change

  • fix cli for createGauge
  • add gas cost that scales linearly y with coins to add

Testing and Verifying

  • tested CreateGauge and checked gas consumption

Documentation and Release Note

n/a

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@stackman27 stackman27 added A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jun 13, 2023
p0mvn
p0mvn approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please add a changelog entry prior to merge

@p0mvn p0mvn merged commit bd809a9 into main Jun 17, 2023
1 check passed
@p0mvn p0mvn deleted the stack/gauge-cleanup branch June 17, 2023 22:23
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
A:no-changelog C:CLI C:x/incentives V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stackman27 @p0mvn @mattverse