Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.43.0 upgrade WIP #419

Closed
wants to merge 4 commits into from
Closed

v0.43.0 upgrade WIP #419

wants to merge 4 commits into from

Conversation

antstalepresh
Copy link
Contributor

No description provided.

@antstalepresh antstalepresh marked this pull request as draft August 18, 2021 12:32
@faddat
Copy link
Member

faddat commented Oct 2, 2021

Hey, I am (attempting to) do 0.44.1 today.

Feel free to follow along in branch fortyfourone

@faddat
Copy link
Member

faddat commented Oct 12, 2021

Will try and make branch for this.... it is good but not perfect:

suspected issues

  • Not chopping them round correctly in the decimal math file in the Osmosis fork of cosmos sdk
  • cleanup
  • pulling changes from main back into my fortyfourone branch

@faddat
Copy link
Member

faddat commented Oct 15, 2021

Khanh has made it suck far less now:

https://github.com/osmosis-labs/osmosis/tree/faddat/sdk-0441

@ValarDragon
Copy link
Member

Awesome, we should probably close this in favor of that work

@faddat faddat mentioned this pull request Oct 17, 2021
Merged
13 tasks
@ValarDragon ValarDragon deleted the sdk_v43_upgrade branch August 4, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic will be requested when the pull request is marked ready for review czarcas7ic is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn will be requested when the pull request is marked ready for review p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu will be requested when the pull request is marked ready for review AlpinYukseloglu is a code owner

@mattverse mattverse Awaiting requested review from mattverse mattverse will be requested when the pull request is marked ready for review mattverse is a code owner

@nicolaslara nicolaslara Awaiting requested review from nicolaslara nicolaslara will be requested when the pull request is marked ready for review nicolaslara is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antstalepresh @faddat @ValarDragon