refactor(gamm): improve error handling and messages when parsing pool assets #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
github-actions
bot
added
the
C:x/gamm
p0mvn
changed the title
ValarDragon
approved these changes
Sep 28, 2022
ValarDragon
added
V:state/compatible/backport
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
… assets (#2804) Closes: #XXX ## What is the purpose of the change The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages. This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? yes - How is the feature or change documented? not applicable (cherry picked from commit f024498) # Conflicts: # CHANGELOG.md
p0mvn
added a commit
that referenced
this pull request
Oct 1, 2022
… assets (backport #2804) (#2901) * resolve conflicts * Update CHANGELOG.md Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
The errors were non-descriptive, and, as a result, making the debugging experience more difficult. This refactor improves error messages.
This is not state breaking because we still return error if any of the denoms are missing. Error messages do not affect state breaks
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes