refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper method #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
approved these changes
Aug 19, 2022
p0mvn
added a commit
that referenced
this pull request
Aug 19, 2022
… method (backport #2418) (#2456) * refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper method (#2418) * refactor(x/mint): remove SetInitialSupplyOffsetDuringMigration keeper function * changelog * resolve merge conflict (cherry picked from commit 3d7d48c) # Conflicts: # CHANGELOG.md # x/mint/keeper/keeper_test.go * Fix conflict Co-authored-by: Roman <[email protected]> Co-authored-by: Dev Ojha <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
SetInitialSupplyOffsetDuringMigrationis only used in v7 upgrade. We should never need to use this method anymore. As a result, I propose removing it while keeping the note in v7 upgrade handler about this historic method.Anyone interested in the historic implementation can check out the v7 branch and see the implementation.
It is useful to avoid having obsolete methods for simplicity of packages and fewer potential sources of misuse and bugs
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes