Fix snapshot manager with wasm #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@faddat Thank you so much for this change. Is it possible to open this PR against Once merged to main, we can then easily backport this to v9 by using the |
Closed
|
Yep, happy to. Confusion was related to |
faddat
force-pushed
the
faddat/fix-snapshot-manager
branch
from
43b3c68
to
caa8190
Compare
p0mvn
added
A:backport/v10.x
|
@faddat thanks again for this change. I'm going to add to this PR to merge and reconcile the differences with |
p0mvn
approved these changes
Jun 16, 2022
ValarDragon
approved these changes
Jun 16, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Update app.go * Update app.go * fmt and changelog Co-authored-by: Roman <[email protected]> (cherry picked from commit 8e1b620)
ValarDragon
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Update app.go * Update app.go * fmt and changelog Co-authored-by: Roman <[email protected]> (cherry picked from commit 8e1b620) Co-authored-by: Jacob Gadikian <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1697
What is the purpose of the change
Registers wasm snapshotter as an extension to the snapshot manager. This is one of the few fixes needed to re-enable state-sync in Osmosis. The latest state of state-sync is discussed here: #1805
Brief Changelog
Testing and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes