prevent mouse wheel from changing input on add liquidity step

[MaxMillington]

What is the purpose of the change:

We want to prevent the liquidity input from changing when user uses the mouse scroll

Linear Task

https://linear.app/osmosis/issue/FE-1187/disable-mouse-scroll-wheel-for-liquidity-amount-input

Brief Changelog

• disable mouse scroll for add liquidity amount

Testing and Verifying

This change has been tested locally by rebuilding the website and verified content and links are expected

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 1:31pm

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Nov 1, 2024 1:31pm
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Nov 1, 2024 1:31pm
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Nov 1, 2024 1:31pm
osmosis-testnet	⬜️ Ignored (Inspect)			Nov 1, 2024 1:31pm

[coderabbitai]

Walkthrough

The changes in this pull request modify the InputBox component in input-box.tsx by introducing an onWheel event handler to prevent scrolling when the input is focused and updating the onBlur event handler to manage the inputFocused state more effectively. These modifications enhance user interaction control with the input fields.

Changes

File	Change Summary
packages/web/components/input/input-box.tsx	Added onWheel event handler to blur input on wheel events; updated onBlur handler to set inputFocused to false and allow an optional callback.

Possibly related PRs

• fix: keyboard reopening denom selection modal for buy/sell #3883: The changes in this PR also involve managing focus behavior by blurring an element (e.currentTarget.blur();) after an interaction, similar to the onBlur event handler updates in the main PR.

Suggested reviewers

• DavideSegullo

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/web/components/input/input-box.tsx (1)

Line range hint 143-147: LGTM with a minor suggestion: Consider extracting the wheel handler

The implementation correctly prevents scroll wheel input and properly manages focus state. However, since the wheel handler is identical for both input types, consider extracting it to reduce duplication.

Consider extracting the wheel handler to a constant:

+ const handleWheel = (e: WheelEvent) => (e.target as HTMLInputElement).blur();

  return (
    // ...
          <AutosizeInput
-           onWheel={(e) => (e.target as HTMLInputElement).blur()}
+           onWheel={handleWheel}
            // ...
          />
          <input
-           onWheel={(e) => (e.target as HTMLInputElement).blur()}
+           onWheel={handleWheel}
            // ...
          />

🧰 Tools

🪛 Biome

[error] 146-146: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b8012ce and bb89a19.

📒 Files selected for processing (1)

• packages/web/components/input/input-box.tsx (2 hunks)

🔇 Additional comments (2)

packages/web/components/input/input-box.tsx (2)

120-120: LGTM: Wheel event handler for AutosizeInput

The implementation effectively prevents scroll wheel from modifying the input value by blurring the field when a wheel event occurs.

---

120-120: Implementation successfully addresses PR objective

The changes effectively prevent mouse wheel from modifying input values by:

1. Adding wheel event handlers to both input types
2. Using field blur to prevent value changes
3. Maintaining proper focus state management

This implementation successfully addresses the issue described in FE-1187.

Also applies to: 143-147