Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish Stage #3697

Merged
merged 16 commits into from
Aug 8, 2024
Merged

Publish Stage #3697

merged 16 commits into from
Aug 8, 2024

Conversation

yury-dubinin
Copy link
Contributor

@yury-dubinin yury-dubinin commented Aug 7, 2024 •
edited by JoseRFelix
Loading

Following changes are ready for Publish:

  • Add amplitude analytics
  • Removed duplicating sqs alerts (no impact)
  • (Deposit/Withdraw) Improve amount screen loading experience
  • Limit orders
  • Limit Orders: QA Fixes
  • Limit Orders and Swap Flow Redesign
  • (Deposit/Withdraw) Support trx and trx.rt tokens
  • fix trade widget search
  • fix: bandaid overflow fix for order history table
  • (Deposit/Withdraw) Fix Crypto Fiat Input Loading and Handle Provider Request Error

mattupham and others added 3 commits August 7, 2024 08:51
@mattupham
Add amplitude analytics (#3689)
3d2fadf 
* Add amplitude analytics

* Add analytics
@yury-dubinin
Removed duplicating sqs alerts (#3696)
985f675
@JoseRFelix
(Deposit/Withdraw) Improve amount screen loading experience (#3687)
5ebe930 
* feat: add error box message

* feat: improve error messaging and placement

* improvement: use required dependency keys

* improvement: add comment

* feat: initial loading changes

* feat: add loading state to amount screen

* fix: remove unused code

* improvement: chain loading

* fix: run prettier

* fix: connect wallet redirect

* fix: add additional condition for external withdraw

* improvement: @jonator feedback
@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview ✅ 3 resolved Aug 8, 2024 8:06pm
osmosis-frontend-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 8:06pm
osmosis-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 8:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2024 8:06pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Aug 8, 2024 8:06pm

jonator and others added 11 commits August 7, 2024 17:12
@jonator
try asset list first, then chain list (#3700)
ecdb77d
@mattupham
Revert "Flip USDC by default (#3614)" (#3699)
be7fcba 
This reverts commit 213126c.
@crnbarr93 @fabryscript
@sunnya97 @DavideSegullo @jonator
Limit Orders and Swap Flow Redesign (#3683)
aab2946 
* feat: create generic disclaimer tooltip

* fix: enable propagation on generic disclaimer

* feat: re-arrange and update market trade details

* feat: add free state to trade details

* feat: re-arrange limit order fees

* feat: add gas icon

* feat: move and update review-swap into review-order

* feat: re-implement review-order modal

* feat: added gas fee esimate to place limit state

* feat: reduced fee estimate calls

* feat: add button disabling on review modal

* fix: removed repeating asset price query

* fix: adjusted placed quantity to be exact input

* fix: remove unused var

* refactor: remove old limit order review modal and extract recap row

* feat: add high slippage warning to review order

* feat: inject maxSlippage into usePlaceLimit hook

* chore: remove useless style from GenericDisclaimer

* feat: add gas icon to limit trade details network fees recap row

* feat: add tooltips to trade details row

* build: fixed translation json error

* redesign swap widget (#3591)

* fix: fixed isTyping field for inAmountInput

* Improve rate info (#3588)

* rate

* fix build lint

* improve buy/sell view

* Update packages/web/components/swap-tool/trade-details.tsx

Co-authored-by: Connor Barr <[email protected]>

* undo inlang change

---------

Co-authored-by: Connor Barr <[email protected]>

* fix: fix missing attributes

* feat: redesign widget base layout & top selectors

* chore: remove unused old commented code

* chore: remove tab uqs

* feat: update token selection & input/output designs

* feat: redesign quote selection

* feat: WIP redesign limit price selector and update page widget size

* fix: invert triangles direction and comment out unused code

* fix: fix button click disabled when tooltip open

* feat: re-implement open orders card

* feat: WIP init implementing focus switching

* feat: add switching button UI

* feat: change default percent adjustment and label render logic

* feat: re-add trade details

* chore: remove unused code

* refactor: extract AssetFieldset

* chore: comment out unused code

* feat: wire-up trade details limit variant

* feat: WIP implement new swap tool designs

* refactor: moved order mapping to caching function

* build: fixed build errors

* feat: added refetch to cancel/claim [WARNING DO NOT TEST]

* fix: fixed refetching on order table

* feat: finish implementing swap tool redesign

* feat: add popover on limit order disabled & tweak GenericDisclaimer customization

* feat: refetch orders on first load

* feat: add "add funds" button to asset fieldset header balance

* feat: add no balance logics to place limit tool & swap tool

* fix: inputs adjust value of other input for limit orders

* feat: change all site bg & fix earn page radio buttons opacity

* fix: removed unnecessary button disabled state

* fix: removed unnecessary button disabled state

* feat: add trade bg

* chore: removed unused code

* fix: fixed price input error on 0 input

* fix: fixed rounding issue with max button

* fix: fix faulting overflow-hidden on alt swap tool

* fix: fix bar width

* fix: fix alt swap tool labels

* fix: fix scroll on home fixed container

* fix: fix "add funds" display on wallet disconnected

* fix: fix alt headers and remove old code

* fix: fix spacing on tool

* fix: fix trade details bugged animation

* feat: add prefixes/suffixes empty states

* fix: disable ticker on sell tab balance

* fix: fix sell balance precision & fieldset footer height

* fix: fix buy available usdc amount formatting

* feat: update selectableQuotes to cover wallet not connected case

* fix: hide add funds button when wallet is disconnected

* fix: hide add funds cta on price selector and fix lint

* fix: filter in UI default quotes on defaultQuotesWithBalances

* feat: add empty states to swap widget footers

* feat: make "stablecoin" tooltip trigger underlined

* fix: update decimal places and add "<$0.01" to trade details fees

* build: fixed build errors

* fix: update display of gasUsdValueToPay

* feat: update rendering of gasAmount and wire it up on swap tool

* refactor: updated button disabled & loading states

* fix: update gas display on review modal

* chore: readded insufficient balance display to hidden error messages

* fix: update chart icon size and variant display logic

* feat: remove triangle indicator when percentAdjusted is zero

* fix: update token-details-shadow color

* chore: sentence case adjustments

* fix: fixed review modal changing price and incorrect values

* feat: WIP add scaling to asset input

* fix: fix rounding issues on order type selector and wrapping on parent container

* fix: move isValidNumericalRawInput validation to useLimitPrice

* refactor: move orderType prop computation to ReviewOrder and remove unused prop

* fix: fixed low price value display in limit price selector

* feat: WIP add diffGteSlippage handling

* fix: update isManualSlippageTooHigh treshold

* feat: truncate last slippage number if it's gt 50

* feat: add isManualSlippageTooLow disclaimer and update designs

* fix: fix max button spinner distortion

* fix: fix sticky scroll bg color to thead

* feat: add tooltip on order history page

* feat: update order history columns

* fix: fixed overflow on trade details and insufficient funds not disabling review button

* fix: added label for limit price input and fixed hover state for denom selection

* feat: button hover states for price selection

* fix: removed place limit msg generation for market orders

* build: fixed build error

* fix: adjusted text overflow for expected output

* feat: ✨ add limit orders localizations

* feat: added no gas fee estimation state to trade details

* feat: added gas estimate changes to review order

* chore: machine translate

* chore: added more localisations

* feat: added refetchOnMount to all/claimable orders queries

* fix: filtered unwanted quote assets

* feat: added amount formatting for quote denom selection

* refactor: refactored balance queries in placelimit hook

* fix: 💄 fix order history table overflow (#3649)

* fix: fixed modal not being attached to top of screen for denom selection

* fix: 💄 fix trade widget overlap with sidebar

* feat: clear denom selection on modal close

* fix: undid regression

* feat: ✨ add missing translation and fix analytics event page

* fix: 🐛 fix build error

* fix: removed limit price display in review modal on swap tab

* fix: fixed available amount formatting for buy/sell tab

* feat: moved error display

* fix: disabled button on no funds

* fix: limited decimal input to 3 decimal places

* fix: removed gas fee estimation from trade details

* feat: added state for no routes in trade details

* feat: focus input on swap for buy/sell

* feat: automatically display base denom in trade details

* fix: non-focused percentage 3 decimal places

* refactor: altered trade details outAsBase state and added more localisations

* [WIP] feat: price selection has default value

* fix: hid routes chevron when no routes found

* fix: fixed swap tool layout on pools page modal

* fix: background colors for pool page

* fix: background colour changes

* fix: review order terminology changes

* fix: trade-tokens terminology and padding changes

* fix: adjusted ttl for all orders cache

* refactor: changed cache times for orders

* refactor: altered cache times and added logs for active orders query

* feat: small improvement to all orders query

* chore: cleaned up logs

* fix: active orders optimisation

* fix: fixed bug with input form not resetting

* fix: refetch orders when order placed

* fix: caching trade tool active orders query to orders history page

* fix: readded claim all orders function

* refactor: refactored price input to be simpler

* fix: updating price while in percent mode for price selection

* feat: extreme value handling

* feat: extreme value handling

* fix: small bug fixes

* fix: price adjustment as spot price changes in price selection, removed unused log

* feat: spinner/disabled look for claim & close button

* fix: fixed above/below display for price selector

* fix: show order history link when user has any order history

* fix: fixed font scaling for inputs

* fix: reworked order history page

* chore: removed old order history page

* build: fixed build error

* fix: small changes to order history

* build: fix build errors

* feat: moved orderbook denom query to sqs pools

* fix: more active orders query changes

* feat: added no wallet state for order history

* fix: wallet loading state order history page

* feat: limits can now be placed on opposite side of market price

* chore: localisations

* fix: fixed error on high price amount inputs

* fix: small percentage adjustments for price input

* chore: removed logs, small formatting adjustment

* fix: toggle background colours for limit order ff

* fix: percent fill rounding

* feat: added geolocation based feature flags for limit orders

* fix: improved feel of cancel/claim buttons

* fix: correct swap tool depending on feature flags

* fix: missed backgrounds for feature flags

* build: fix build errors

* fix: remove swr and invalidate orderbook queries on tx

* refactor: moved historical orders query, fixed schema issue

* chore: removed unused code

* chore: reduced use of useMemo where possible

* chore: remove unused code

* test: moved tickToPrice to jest in case

* chore: added debug logs for claim/cancel buttons when no wallet found

* feat: added intersection component to orders history

* feat: valid/default limit quote denoms uses MainnetAssetSymbols

* fix: feature flag bg colour in main

* feat: added placeholder prop to ScaledCurrencyInput

* build: fixed build errors

* feat: undid order history first column changes from yesterday

* test: added unit tests for new formatter functions

* refactor: moved countDecimals test to correct file

* refactor: ♻️ add useKeyboardNavigation instead of custom implementation

* chore: added comments to disabled hooks in various places

* fix: 🐛 fix build error

* lint

* clean up unused localizations

* remove tests for old swap tool (deprecated)

---------

Co-authored-by: fabryscript <[email protected]>
Co-authored-by: Fabrizio Emanuele Piperno <[email protected]>
Co-authored-by: Sunny Aggarwal <[email protected]>
Co-authored-by: Davide Segullo <[email protected]>
Co-authored-by: Jon Ator <[email protected]>
@JoseRFelix
(Deposit/Withdraw) Support trx and trx.rt tokens (#3702)
6ae74e9 
* feat: support trx and trx.rt tokens

* improvement: @jonator feedback
@mattupham
preserveAspectRatio (#3701)
e66d5e7
@DavideSegullo
feat: add test id (#3704)
e0fef20 
* feat: add test id

* feat: ✨ add swap input test id

* feat: ✨ add test id

* feat: ✨ add token-price test id

* feat: ✨ add token in/out test id
@DavideSegullo
fix: 🐛 fix trade widget search (#3705)
2c8555b
@crnbarr93
[Limit Orders]: QA Fixes (#3707)
6a1a2d3 
* fix: portfolio page bg

* fix: asset table header background

* fix: fixed input height

* fix: fixed order history virtualization

* chore: lcoalizations

* fix: portfolio feature flag

* chore: removed unused virtualization parameter

* chore: reverted unnecessary changes

* fix: added scaling to output for swaps

* fix: hide generic error text

* fix: small adjustment to claimable orders query

* chore: lint

* test: fix localizations test

* test: fixed failing test

* fix: temporary fix for order history table
@yury-dubinin
Move E2E tests to a new Trade page (#3706)
f87b321 
* Move select tests to Trade page
* Update test workflows
@crnbarr93
fix: bandaid overflow fix for order history table (#3708)
32b4840
@mattupham
Mattupham/fe 965 portfolio add cypher card (#3711)
df04618 
* add card

* Plug in cypher card

* Add feature flag

* Clean up styles
@JoseRFelix JoseRFelix merged commit 756fb9f into master Aug 8, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseRFelix JoseRFelix JoseRFelix approved these changes

@jonator jonator jonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yury-dubinin @jonator @JoseRFelix @mattupham @crnbarr93 @DavideSegullo