chore: fix CI#509
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Returns start time, periods, and error. | ||
| func readScheduleFile(path string) (int64, []types.Period, error) { | ||
| contents, err := ioutil.ReadFile(path) | ||
| contents, err := os.ReadFile(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
czarcas7ic
commented
Jan 31, 2024
|
|
||
| req := &banktypes.QueryTotalSupplyRequest{} | ||
| testdata.DeterministicIterations(suite.ctx, suite.Require(), req, suite.queryClient.TotalSupply, 243, false) | ||
| testdata.DeterministicIterations(suite.ctx, suite.Require(), req, suite.queryClient.TotalSupply, 3285, false) |
Member
Author
There was a problem hiding this comment.
This was strange to me, although I know we modified the bank query logic so it makes sense the gas used is different.
czarcas7ic
commented
Jan 31, 2024
| suite.Require().NoError(suite.bankKeeper.MintCoins(suite.ctx, minttypes.ModuleName, sdk.NewCoins(coin))) | ||
| req := &banktypes.QuerySupplyOfRequest{Denom: coin.GetDenom()} | ||
| testdata.DeterministicIterations(suite.ctx, suite.Require(), req, suite.queryClient.SupplyOf, 1021, false) | ||
| testdata.DeterministicIterations(suite.ctx, suite.Require(), req, suite.queryClient.SupplyOf, 2033, false) |
mattverse
approved these changes
Feb 1, 2024
|
@czarcas7ic lol sorry for deleting the whole thing, thanks. Planning to merge this as soon as CI passes |
Member
Author
|
Thanks, my hope is the labeler will get fixed after merged, i think its a perms thing that requires it to be in main |
Member
Author
|
Lets remove the sonar cloud step from repo-analysis |
|
@czarcas7ic I'll do that in a subsequent PR |
Member
Author
|
oh lol im sorry @mattverse i just did it |
|
@czarcas7ic GOAT |
czarcas7ic
added a commit
that referenced
this pull request
Feb 8, 2024
* De-dup param getting * Disable DenomOwners tracking * Fix some tests * chore(types): replace amino json encoder with stdlib * feat: config option to log gRPC queries (#503) * config option to log gRPC queries * clarify gRPC log comment * create var * remove quotes * go mod tidy * chore: fix CI (#509) * ci * lints and remove some unnecessary CI jobs * update tests go mod * more lints * remove denom owners since not implemented in osmosis * more lints * fix test values * implement nolint again * more test fixes * add back labeler as v4 * remove tabs and slash * update json to const * move file locations * push * fix seq num issue * Update tests/e2e/auth/vesting/suite.go * add back pwd * remove sonarcloud --------- Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> * Fix CI(#511) * perf: CacheCtx speedups (#504) * CacheKV speedups * Remove extra btree alloc * fix(x/feegrant)!: limit expired feegrant pruning to 200 per block (cosmos#19314) (#512) Co-authored-by: MSalopek <matija.salopek994@gmail.com> * feat: add testnetify logic (#506) * add testnetify logic * clarify explanation * handle errors * remove testnet app creator * simplify some logic * remove redundancy * lints * gci imports * add set store loader method * trigger upgrade flag * add extra comments to the CLI command * skip confirmation (#516) --------- Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: MSalopek <matija.salopek994@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some lingering issues that have been preventing the CI from properly working.