Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "chore: backport #13063 from cosmos/cosmos-sdk #323" #327

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Sep 13, 2022

This reverts commit 870132d.

Closes: #XXX

What is the purpose of the change

It seems that this change broke some of the tests related to:
https://github.com/cosmos/ibc-go/blob/9fa6008f0b8240164e4c3632dbf1c29f744b58eb/modules/core/keeper/msg_server.go#L391-L403

Reverting temporarily to unblock v12

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title Revert "chore: backport #13063 from cosmos/cosmos-sdk #323" chore: Revert "chore: backport #13063 from cosmos/cosmos-sdk #323" Sep 13, 2022
@p0mvn p0mvn marked this pull request as ready for review September 14, 2022 00:11
@p0mvn p0mvn requested a review from a team September 14, 2022 00:11
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK revert

@p0mvn p0mvn merged commit c6be459 into v0.45.0x-osmo-v12 Sep 14, 2022
@p0mvn p0mvn deleted the roman/revert-cache-ctx branch September 14, 2022 00:50
czarcas7ic pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants