Code refactored for atlas start and end route paths #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varaprasad6700
suggested changes
Nov 6, 2023
src/main/java/org/openstreetmap/atlas/geography/atlas/routing/AllPathsRouter.java
Show resolved
Hide resolved
added 2 commits
November 6, 2023 11:27
saveerreddy
approved these changes
Nov 6, 2023
matthieun
approved these changes
Nov 9, 2023
|
Changes look good to me. @matthieun pls merge it. |
Huyuntj
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Generating invalid routes for complex bigNodes
Solution
Process if we have not yet visited the path/edge for start and end in any direction (It would be really weired to revisit an edge/path in a BigNode, both in forward and reverse directions.
Potential Impact:
Should able to generate valid start to end routes
Unit Test Approach:
Added unit tests
Test Results:
Ran locally using tests which is generating expected routes
In doubt: Contributing Guidelines