Dependency updates (follow up of #780) #782
Conversation
tsmock
force-pushed
the
dependency-updates
branch
from
ac0fdff to
31b52c3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
matthieun
left a comment
matthieun
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for doing all that maintenance!
Just a question about the upload of archives to maven central...
| slf4j: "org.apache.logging.log4j:log4j-slf4j-impl:${versions.log4j}", | ||
| ], | ||
| opencsv: "net.sf.opencsv:opencsv:${versions.opencsv}", | ||
| google_truth: "com.google.truth:truth:${versions.google_truth}", |
There was a problem hiding this comment.
You can thank the testing for Checkstyle for that, as I noted in a comment, "Google Truth is needed for checkstyle tests (as of checkstyle 9.2.1)".
| } | ||
|
|
||
| uploadArchives | ||
| publishing |
There was a problem hiding this comment.
So I remember this upload step being very finicky, but that was years back. Have you had any chance to test this new approach?
There was a problem hiding this comment.
Short answer: no.
Longer answer: the comments indicated that it was due to two problems, travis-ci/travis-ci#9555 and an issue with uploads to the Sonatype repo requiring the same IP. AFAIK, atlas isn't using Travis anymore (but I could definitely be wrong about this), so 9555 isn't an issue. And I don't believe that GitHub actions will rotate IP address per upload.
It should work, but I've never published to Sonatype. I want to say one of the other projects I have worked on did something similar, but I cannot remember which project at this point.
This only updates dependencies that did not require code rewriting. Dependencies that require code rewriting include osmosis, which blocks protobuf. Signed-off-by: Taylor Smock <[email protected]>
BeanUtils 1.9.2 added the ability to prevent access to the `class` field. BeanUtils 1.9.4 prevented this by default. The specific test used the `class` field to check for non-instantiable object handling. Signed-off-by: Taylor Smock <[email protected]>
This required updating some classes, as one of the primary differences is support for Java 8 AutoCloseable. Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Also, some prework for Gradle 7.x. Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
Signed-off-by: Taylor Smock <[email protected]>
tsmock
force-pushed
the
dependency-updates
branch
from
4cdd6a1 to
e319b6d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
3 participants
Description:
Update remaining dependencies
Major updates:
release->close, as osmosis updated to Java 8 supportatlasbuilt in this PR for checkstyle checks due to checkstyle incompatibilities. The checkstyle update also forced some code changes, due to new/fixed checksatlas-generatorPotential Impact:
Downstream users will need to update their dependencies (specifically,
checkstyle), which will most likely force code changes.Unit Test Approach:
N/A
Test Results:
Timings from
./gradlew runinatlas-checksfor NZL:I'm uncertain what happened with the two original runs (10%+ difference), however, the second non-updated run was about the same as the two runs with updates. It could be a simple as different software running on the laptop used.
In doubt: Contributing Guidelines