Skip to content

Conversation

@matthieun
Copy link
Collaborator

Description:

Attempt to fix a build issue with osgeo rejecting log4j1 calls by putting maven central first in the repo list.

Potential Impact:

May unblock builds

Unit Test Approach:

None

Test Results:

None


In doubt: Contributing Guidelines

@tsmock
Copy link
Contributor

tsmock commented Jan 13, 2022

@matthieun : You might want to take a look at 7a9a179 (in #196 ).

@tsmock
Copy link
Contributor

tsmock commented Jan 13, 2022

@matthieun : If it helps, osgeo messed things up when they removed log4j 1.2.17 (they replaced it with a -norce version). They did not remove the pom file for log4j 1.2.17, which is what caused the original issue.

The simplest workaround is to exclude log4j 1.2.17 from the osgeo repository (see 7a9a179 for how to do that).

@matthieun
Copy link
Collaborator Author

@tsmock Thanks I will add the same exclude too then. Also putting maven central first worked, but for some reason it would fail with javax/media/jai_core/1.1.3 since maven central has the pom but osgeo has the jar... 👎
Had to add osgeo as a jar supplier for maven central.
That way most artifacts are downloaded from maven central now.

@matthieun matthieun marked this pull request as ready for review January 13, 2022 19:11
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lucaspcram lucaspcram merged commit 70a71ff into osmlab:dev Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants