-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Through railways include branch lines #808
Conversation
Was this feedback from a North American, or someone from elsewhere? I understand "mainline track" to be |
Yes, this was feedback from a North American, albeit someone deeply familiar with OSM’s railway tagging scheme. I’m not well-versed in rail in general, so “mainline” was the best I could come up with at the time in #632. |
Not a rail expert, but would "Main or branch line track" still convey the same meaning a little more concisely? Or does "mainline" have to be one word? |
One thing that would be neat (way beyond the scope of this PR) would be to have an option to "translate" the legend into OSM tags, so you could see which tags the style interprets into which symbols. So in this case, rather than "Mainline track" it could say " |
Perhaps we could call |
Sure, we can factor out “line”.
Ideally, it would be up to the OSM Wiki to better associate raw tags with real-world terminology, and up to OpenMapTiles to better document how it translates raw OSM tags to its own schema. We do bake in assumptions about these translations into our taginfo project file, but it’s fragile; baking in assumptions about OSM tag semantics at the same would be even more fragile. Compounding matters, these entries don’t correspond one-to-one to OMT properties or even Americana’s own style layers. It’s very reader-centric, as any legend would be. I agree that tag debugging tools would be helpful, but a legend isn’t the best form factor for that. Filters and layer properties take more than tags as input, such as zoom levels. It would be worth ticketing out a more straightforward debugging tool, perhaps a combination of maplibre-gl-inspect and #433.
The point of this entry is to distinguish “main” tracks in the sense of not being surrounded by lots of other tracks. That’s what we’ve styled with a little more emphasis than spurs, yard tracks, etc. The spur/yard entry is also conventional rail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current terminology sounds good to me based on discussion above.
We got some private feedback that the legend’s “Mainline track” entry is misleading because it also includes railroad tracks tagged
usage=branch
. OpenMapTiles doesn’t classify railways byusage=*
, and this style doesn’t visually distinguish railways to the extent that this key would be very useful. (It could be useful to a more rail-centric style, however.) Though a little more verbose, “Mainline or branch line track” seems to cover our bases well enough. It doesn’t mention heavy rail, but this is implied by the presence of separate entries for light rail etc.