Fix error when opening legend #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Feb 10, 2023
| @@ -686,8 +686,9 @@ export default class LegendControl { | |||
| if (!networkMetadata) return; | |||
|
|
|||
| let section = document.getElementById("legend-section-shields"); | |||
There was a problem hiding this comment.
We could pull this statement up to the top of the method and short-circuit fetching the metadata from Wikidata. But even if that query runs unnecessarily the first time the user opens the legend, it avoids a flash of raw tag values when opening the legend again in the presence of shields. I think this is a better user experience worth the cost of a relatively small request.
1ec5
force-pushed
the
1ec5-legend-no-shield-section-774
branch
from
823e116 to
653b8a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression from #773 that produces an error when opening the legend: #774 (comment). If there’s no “Route markers” section because no route markers are visible in the current viewport, then there are no pending rows and no need to regenerate them with Wikidata labels.