Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colin:fix-vscodeignore-build-erros-tracking #30

Merged
merged 20 commits into from
Dec 11, 2024
Merged

Conversation

12mv2
Copy link
Collaborator

@12mv2 12mv2 commented Nov 25, 2024

Linked issue/ticket

JIRA-84

Description

This PR addresses two issues:

  1. Added .DS_Store to .gitignore and .vscodeignore to prevent unnecessary system-generated files from being tracked or included in the VS Code extension package.
  2. Removed comments from .gitignore as they were potentially causing errors in some environments during build/package processes.

Reproduction steps

  1. Check that .DS_Store files are no longer included in the Git index or extension package:
    • Run vsce ls and confirm .DS_Store is not listed.
  2. Validate that .gitignore still functions correctly without the removed comments:
    • Create new files matching .gitignore rules and confirm they are ignored by Git.
  3. Build and package the extension using vsce package to ensure no .DS_Store files are included.

Checklist

  • [ x] I've followed the Contributing guidelines
  • [x ] I've titled my PR according to the Conventional Commits spec
  • I've added tests that fail without this PR but pass with it
  • [ x] I've linted, tested, and commented my code
  • [x ] I've updated documentation (if appropriate)

12mv2 and others added 20 commits November 14, 2024 14:28
…elopment

- Updated the watch script in package.json to use concurrently with direct commands for:
  - webpack --watch to monitor and rebuild frontend files.
  - tsc -watch -p ./tsconfig.json to monitor and compile backend files.
- Removed redundant frontend:watch and backend:watch scripts for cleaner package.json.
- Verified functionality with successful compilation of both frontend (React webview) and backend (TypeScript extension).

This update simplifies the development workflow by enabling simultaneous watching with a single command: npm run watch.
…json-both-dev-prod

Colin/update webpack package.json both dev prod
@12mv2 12mv2 requested review from MZiegler96 and susanalam December 2, 2024 05:22
@12mv2 12mv2 self-assigned this Dec 11, 2024
@12mv2 12mv2 changed the base branch from dev to main December 11, 2024 06:08
@12mv2 12mv2 merged commit 9dc7f0c into main Dec 11, 2024
2 checks passed
@12mv2 12mv2 deleted the colin/fix-vscodeignore-erros branch January 7, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants