-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package): Update pyproject.toml for poetry 2.0 in project and template #333
Conversation
@xmnlab I cannot execute |
Remember to install poetry 2 manually in your environment |
@YurelyCamacho , in toml files, inside dictionaries you should use =, instead of : |
license = "{{ cookiecutter.project_license }}" | ||
dependencies = [ | ||
{%- if cookiecutter.documentation_engine == 'quarto' or cookiecutter.sphinx_theme == 'pydata' or cookiecutter.jupyter_book_theme == 'pydata-sphinx-theme' %} | ||
"python >= 3.9,<4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In both, if and else, the output is the same .. so it is not necessary to have if/else
But any way .. the python souldn't be listed in rhe dependencies anymore .. it should be moved to another entry called require-python. Please check examples in the issue for more references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I had placed it there but I don't know why I later deleted it. I'll put it back
@xmnlab I have made several changes and cannot find the error. I think it is in the pyproject.toml of the template. I have tried several things and I still don't get it. When I run poetry lock I get 'name'. |
As you can see in the CI .. it fails in the beginning, before tests .. so it means that it is not the pyproject.toml of the template, instead it is the pyproject of the project. Does it make sense? |
Remember to remove poetry.lock and regenerate it again please |
thank you @YurelyCamacho |
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: