Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): Update pyproject.toml for poetry 2.0 in project and template #333

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

YurelyCamacho
Copy link
Collaborator

Pull Request description

  • Update pyproject.toml file in project and template for poetry 2.0 and makim 1.20.0
  • Update dev.yaml and dev-win.yaml files for makim 1.20.0 and poetry 2.0

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • [ X] maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@YurelyCamacho YurelyCamacho requested a review from xmnlab January 14, 2025 01:24
@YurelyCamacho
Copy link
Collaborator Author

@xmnlab I cannot execute poetry lock because I get 'list' object has no attribute 'keys'. I changed the = in the dictionaries to : and it doesn't work either. And I looked at the references you left and it looks like this.

@xmnlab
Copy link
Member

xmnlab commented Jan 14, 2025

Remember to install poetry 2 manually in your environment

@xmnlab
Copy link
Member

xmnlab commented Jan 14, 2025

@YurelyCamacho , in toml files, inside dictionaries you should use =, instead of :

license = "{{ cookiecutter.project_license }}"
dependencies = [
{%- if cookiecutter.documentation_engine == 'quarto' or cookiecutter.sphinx_theme == 'pydata' or cookiecutter.jupyter_book_theme == 'pydata-sphinx-theme' %}
"python >= 3.9,<4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both, if and else, the output is the same .. so it is not necessary to have if/else

But any way .. the python souldn't be listed in rhe dependencies anymore .. it should be moved to another entry called require-python. Please check examples in the issue for more references.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I had placed it there but I don't know why I later deleted it. I'll put it back

@YurelyCamacho
Copy link
Collaborator Author

@xmnlab I have made several changes and cannot find the error. I think it is in the pyproject.toml of the template. I have tried several things and I still don't get it. When I run poetry lock I get 'name'.

@xmnlab
Copy link
Member

xmnlab commented Jan 14, 2025

As you can see in the CI .. it fails in the beginning, before tests .. so it means that it is not the pyproject.toml of the template, instead it is the pyproject of the project. Does it make sense?

@xmnlab
Copy link
Member

xmnlab commented Jan 14, 2025

https://github.com/osl-incubator/scicookie/actions/runs/12774581517/job/35609009185#step:5:10

Remember to remove poetry.lock and regenerate it again please

@YurelyCamacho YurelyCamacho marked this pull request as ready for review January 17, 2025 16:52
@YurelyCamacho YurelyCamacho requested a review from xmnlab January 17, 2025 16:52
@xmnlab xmnlab merged commit ffa46e5 into osl-incubator:main Jan 17, 2025
20 checks passed
@xmnlab
Copy link
Member

xmnlab commented Jan 17, 2025

thank you @YurelyCamacho

Copy link

github-actions bot commented Feb 6, 2025

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants