Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldmapper improvements #57

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Conversation

nemecec
Copy link

@nemecec nemecec commented Jan 17, 2021

Two small improvement suggestions (related to issue #55):

  • Include the actual pattern constant in the exception message, to make sure they do not get out of sync
  • Avoid map lookup for better performance

@osiegmar osiegmar merged commit bf8180a into osiegmar:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants