Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GZIP Compression with GelfUdpAppender #66

Closed
Stratehm opened this issue Nov 23, 2021 · 1 comment
Closed

GZIP Compression with GelfUdpAppender #66

Stratehm opened this issue Nov 23, 2021 · 1 comment
Labels
enhancement
Milestone
5.0.0

Comments

@Stratehm
Copy link
Contributor

Problem:
We have an application that sends logs to a Logstash instance but all special characters are badly handled. It seems that Logstash has a problem when using ZLIB compression but works well with GZIP compression (tested and approved). (logstash-plugins/logstash-input-gelf#54)

Solution
We would like to be able to use GZIP compression instead of ZLIB since this compression method is also permitted in the GELF specs: https://docs.graylog.org/docs/gelf#gelf

A solution may be to add a <compressionMethod>GZIP/ZLIB</compressionMethod> configuration to the GelfUdpAppender and taken into account only if <useCompression> is true.

Alternative solution
Remove <useCompression> configuration (breaking change) and replace it with <compressionMethod>None/GZIP/ZLIB</compressionMethod>
Stratehm pushed a commit to Stratehm/logback-gelf that referenced this issue Nov 23, 2021
@antoinebesnardof
GZIP Compression with GelfUdpAppender (osiegmar#66)
881fc69
Stratehm pushed a commit to Stratehm/logback-gelf that referenced this issue Dec 17, 2021
@antoinebesnardof
GZIP Compression with GelfUdpAppender (osiegmar#66)
0eac63f
@Stratehm Stratehm mentioned this issue Dec 17, 2021
Closed
Stratehm pushed a commit to Stratehm/logback-gelf that referenced this issue Jan 3, 2022
@antoinebesnardof
GZIP Compression with GelfUdpAppender (osiegmar#66)
01d1a9e
@Stratehm Stratehm mentioned this issue Jan 3, 2022
Merged
osiegmar pushed a commit that referenced this issue Jan 4, 2022
@Stratehm @antoinebesnardof
GZIP Compression with GelfUdpAppender (#66) (#77)
6662a97 
Co-authored-by: Antoine BESNARD <[email protected]>
@osiegmar
Copy link
Owner

osiegmar commented Jan 4, 2022

Thanks for your contribution. The functionality will be part of the next non-patch release.

@osiegmar osiegmar added this to the 5.0.0 milestone Dec 23, 2022
osiegmar added a commit that referenced this issue Dec 23, 2022
@osiegmar
refactor compression configuration #66
a9e599a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

GZIP Compression with GelfUdpAppender (#66) Stratehm/logback-gelf
2 participants
@osiegmar @Stratehm