Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 40 additions & 10 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion applications/data_manager/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ duckdb = { version = "1.4.3", features = ["r2d2", "chrono"] }
validator = { version = "0.20", features = ["derive"] }
thiserror = "2.0.3"
sentry = { version = "0.35", features = ["tracing", "reqwest", "rustls"] }
sentry-tower = { version = "0.35", features = ["http"] }
sentry-tower = { version = "0.47", features = ["http"] }
Comment on lines 40 to +41
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Mismatched sentry and sentry-tower versions break integration

sentry is still at 0.35 while sentry-tower has been bumped to 0.47. These two crates are part of the same ecosystem and must be kept in lockstep — as confirmed by the Cargo.lock diff, they now pull in two separate, incompatible versions of sentry-core:

  • sentry 0.35sentry-core 0.35.0
  • sentry-tower 0.47sentry-core 0.47.0

Because Rust treats these as entirely distinct crates at the type level, the global Hub initialized by sentry 0.35 (via sentry-core 0.35.0) is invisible to sentry-tower 0.47 (which calls Hub::current() on sentry-core 0.47.0). The tower middleware will operate against an uninitialized, no-op hub, silently discarding all request-level Sentry context (breadcrumbs, transaction/trace data, user info, etc.) instead of associating it with the configured Sentry client.

Either bump sentry to 0.47 to match, or revert sentry-tower back to 0.35 until a coordinated upgrade is ready.

Suggested change
sentry = { version = "0.35", features = ["tracing", "reqwest", "rustls"] }
sentry-tower = { version = "0.35", features = ["http"] }
sentry-tower = { version = "0.47", features = ["http"] }
sentry = { version = "0.47", features = ["tracing", "reqwest", "rustls"] }
sentry-tower = { version = "0.47", features = ["http"] }
Prompt To Fix With AI
This is a comment left during a code review.
Path: applications/data_manager/Cargo.toml
Line: 40-41

Comment:
**Mismatched `sentry` and `sentry-tower` versions break integration**

`sentry` is still at `0.35` while `sentry-tower` has been bumped to `0.47`. These two crates are part of the same ecosystem and must be kept in lockstep — as confirmed by the `Cargo.lock` diff, they now pull in two separate, incompatible versions of `sentry-core`:

- `sentry 0.35``sentry-core 0.35.0`
- `sentry-tower 0.47``sentry-core 0.47.0`

Because Rust treats these as entirely distinct crates at the type level, the global `Hub` initialized by `sentry 0.35` (via `sentry-core 0.35.0`) is invisible to `sentry-tower 0.47` (which calls `Hub::current()` on `sentry-core 0.47.0`). The tower middleware will operate against an uninitialized, no-op hub, silently discarding all request-level Sentry context (breadcrumbs, transaction/trace data, user info, etc.) instead of associating it with the configured Sentry client.

Either bump `sentry` to `0.47` to match, or revert `sentry-tower` back to `0.35` until a coordinated upgrade is ready.

```suggestion
sentry = { version = "0.47", features = ["tracing", "reqwest", "rustls"] }
sentry-tower = { version = "0.47", features = ["http"] }
```

How can I resolve this? If you propose a fix, please make it concise.


[dev-dependencies]
tokio-test = "0.4"
Expand Down
Loading