Deprecate "teardown infrastructure" GitHub workflow#802
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoved the GitHub Actions workflow file for manual infrastructure teardown that previously allowed operators to trigger Pulumi infrastructure stack teardown with AWS credential configuration and Flox environment activation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the manually-triggered (
No issues found — this is a clean, intentional deletion. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .github/workflows/teardown_infrastructure.yaml | Deleted the manual workflow_dispatch-triggered workflow that ran mask infrastructure stack down via Pulumi. Clean removal with no side effects. |
Reviews (2): Last reviewed commit: "Merge branch 'master' into deprecate-tea..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
Removes the manually-triggered GitHub Actions workflow that tears down infrastructure to reduce the risk of accidental destructive runs.
Changes:
- Delete
.github/workflows/teardown_infrastructure.yamlworkflow.
Comments suppressed due to low confidence (1)
.github/workflows/teardown_infrastructure.yaml:1
- Deleting this workflow removes it from GitHub Actions, but Pulumi production config still lists
teardown_infrastructure.yamlunderfund:githubWorkflowFiles(used to build the OIDC workflow ref allowlist). That leaves stale/extra IAM trust permissions for a workflow that no longer exists and makes it easy to re-enable teardown by re-adding the file without an infra change. Remove this filename from the Pulumi config (and/or update the allowlist source) as part of the deprecation/removal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Overview
Changes
Context
I'd rather just get rid of it to avoid accidental teardowns.
Summary by CodeRabbit