Update Claude instructions/add fix for "update pull request" command#758
Update Claude instructions/add fix for "update pull request" command#758forstmeier merged 4 commits intomasterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughReplaces the GraphQL mutation used for posting PR review comments to reply to existing review threads via addPullRequestReviewThreadReply using parameterized variables (thread ID + body). Also updates CLAUDE.md with expanded contributor guidance and workflow best practices. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR makes two changes: (1) fixes GraphQL mutations in the "update pull request" custom command to use proper parameterized variables (
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| CLAUDE.md | Adds six new development guidelines and tweaks wording on one existing line. Contains a typo on line 63: "write tess" should be "write tests". |
| .claude/commands/update-pull-request.md | Fixes GraphQL mutations to use proper parameterized variables instead of fragile inline string interpolation, improving correctness and security. |
Last reviewed commit: 4324282
There was a problem hiding this comment.
Pull request overview
This PR enhances Claude instructions and fixes GraphQL query syntax in the "update pull request" command. The changes improve documentation clarity and correct a technical issue with string interpolation in GraphQL mutations.
Changes:
- Added six new guidelines to CLAUDE.md covering uncertainty handling, abstraction avoidance, style consistency, test-driven bug fixes, professional tone, and GraphQL API usage
- Updated line 44 in CLAUDE.md to emphasize following commented instructions in GitHub templates
- Fixed GraphQL mutation syntax in update-pull-request.md to use variable parameters instead of inline string interpolation for both
addPullRequestReviewCommentandresolveReviewThreadmutations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CLAUDE.md | Expands development guidelines with new best practices and updates GitHub template usage instructions |
| .claude/commands/update-pull-request.md | Fixes GraphQL mutation syntax to use proper variable parameter passing instead of string interpolation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR makes two changes: (1) fixes GraphQL mutation calls in the "update pull request" custom command to use proper parameterized variables via
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .claude/commands/update-pull-request.md | Fixes GraphQL mutations to use proper parameterized variables (-f flags) instead of inline shell string interpolation, consistent with the query pattern already used elsewhere in the file. No issues found. |
| CLAUDE.md | Minor wording update to template line and six new development guidelines added. All additions are reasonable best practices consistent with existing content. Typo fix ("tess" → "tests") addressed in a separate commit. |
Last reviewed commit: 0453208
Greptile SummaryThis PR makes two categories of changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .claude/commands/update-pull-request.md | Fixes GraphQL mutation from addPullRequestReviewComment (creates pending review) to addPullRequestReviewThreadReply (posts directly to threads). Also parameterizes GraphQL variables properly using -f flags instead of inline string interpolation, and updates resolveReviewThread mutation similarly. |
| CLAUDE.md | Adds six new development guidelines (ask when uncertain, no single-use abstractions, match existing styles, test-first bug fixes, no emojis, prefer GraphQL API) and slightly rewords the GitHub template instruction. |
Last reviewed commit: aaad22f
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR updates Claude instructions with best practices and fixes the GraphQL mutation syntax in the "update pull request" command. The changes include expanding Major changes:
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .claude/commands/update-pull-request.md | Fixed GraphQL mutation to use addPullRequestReviewThreadReply with proper variable syntax, replacing the incorrect addPullRequestReviewComment approach |
| CLAUDE.md | Added best practices for code quality, testing, collaboration, and professional communication standards |
Last reviewed commit: c69d029
Overview
Changes
Context
Minor fix plus a handful of prompts I've come across that seemed helpful.
Summary by CodeRabbit