Skip to content

Add Markdown check/add language-specific triggers#746

Merged
forstmeier merged 4 commits intomasterfrom
expand-and-update-github-code-check-workflows
Feb 4, 2026
Merged

Add Markdown check/add language-specific triggers#746
forstmeier merged 4 commits intomasterfrom
expand-and-update-github-code-check-workflows

Conversation

@forstmeier
Copy link
Copy Markdown
Collaborator

@forstmeier forstmeier commented Feb 4, 2026

Overview

Changes

  • add Rust and Python language-specific path triggers
  • add Markdown check workflow

Context

Markdown checks are already part of the pre-commit check so this is a good thing to add since we'll be working extensively in Markdown going forward.

Summary by CodeRabbit

  • Chores
    • Added change-detection steps to PR validations that detect Markdown, Python, and Rust changes.
    • Gated language-specific code checks so Markdown, Python, and Rust jobs run only when relevant files changed.
    • Improved PR CI efficiency by avoiding unnecessary language-specific checks and reducing wasted runs.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Adds a new GitHub Actions workflow to run Markdown checks on PRs and updates Python and Rust workflows to detect changed files via dorny/paths-filter and conditionally run their checks only when relevant files changed.

Changes

Cohort / File(s) Summary
Markdown workflow
.github/workflows/run_markdown_code_checks.yaml
New workflow triggered on pull_request; adds detect_changes using dorny/paths-filter and a job that checks out code, installs Flox, and runs mask development markdown all when markdown files are detected.
Python workflow (gated)
.github/workflows/run_python_code_checks.yaml
Added detect_changes job (paths-filter) and updated run_python_code_checks to needs: detect_changes with if: needs.detect_changes.outputs.python == 'true'. Outputs mapped from the filter step.
Rust workflow (gated)
.github/workflows/run_rust_code_checks.yaml
Added detect_changes job (paths-filter) and updated run_rust_code_checks to needs: detect_changes with if: needs.detect_changes.outputs.rust == 'true'. Outputs mapped from the filter step.

Sequence Diagram(s)

sequenceDiagram
    participant PR as Pull Request
    participant GH as GitHub Actions
    participant Filter as dorny/paths-filter
    participant Runner as Job Runner
    participant Flox as Flox

    PR->>GH: push PR triggers workflows
    GH->>Filter: run detect_changes (paths-filter)
    Filter-->>GH: outputs (e.g., markdown=true / python=true / rust=true)
    GH->>Runner: start code_checks job if corresponding output == "true"
    Runner->>Runner: checkout repo & setup environment
    Runner->>Flox: install/setup Flox
    Runner->>Flox: run "mask development <lang> all" (e.g., markdown)
    Flox-->>Runner: return results
    Runner-->>GH: report job status
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add Markdown check/add language-specific triggers' accurately captures the main objectives of the PR: adding a new Markdown check workflow and implementing language-specific path-based triggers for Python and Rust workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch expand-and-update-github-code-check-workflows

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator Author

forstmeier commented Feb 4, 2026

@forstmeier forstmeier moved this from To Do to In Progress in Overview Feb 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds language-specific path triggers to CI workflows to optimize build execution and introduces a new Markdown linting workflow.

Changes:

  • Added path filters to Rust and Python workflow triggers to run only when relevant files change
  • Created a new Markdown code checks workflow with appropriate file path triggers

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/run_rust_code_checks.yaml Added path filters for Rust source files and Cargo configuration files
.github/workflows/run_python_code_checks.yaml Added path filters for Python source files and project configuration files
.github/workflows/run_markdown_code_checks.yaml Created new workflow for Markdown linting with path triggers for .md and .markdown files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run_markdown_code_checks.yaml Outdated
Comment thread .github/workflows/run_markdown_code_checks.yaml Outdated
@forstmeier forstmeier added the markdown Markdown code updates label Feb 4, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

This PR adds change-detection gating to the existing Python and Rust CI workflows (via dorny/paths-filter) so those checks only run when relevant files change, and introduces a new Markdown checks workflow that runs mask development markdown all via Flox when *.md/*.markdown files are touched.

The overall approach fits the repo’s existing mask-driven CI pattern and reduces unnecessary CI work on unrelated PRs.

Confidence Score: 3/5

  • Mostly safe to merge once the Coveralls job permissions are made explicit.
  • Workflow gating logic and YAML structure look correct, but the Python workflow’s coverage upload relies on GITHUB_TOKEN without declaring permissions, which can break CI in restricted-token environments.
  • .github/workflows/run_python_code_checks.yaml

Important Files Changed

Filename Overview
.github/workflows/run_markdown_code_checks.yaml Adds Markdown-only workflow using dorny/paths-filter to gate a Flox+mask markdown check job.
.github/workflows/run_python_code_checks.yaml Adds paths-filter gating for Python checks; coverage upload remains, but job lacks explicit token permissions for Coveralls reporting.
.github/workflows/run_rust_code_checks.yaml Adds paths-filter gating for Rust checks to avoid running when no Rust-related files changed.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment thread .github/workflows/run_markdown_code_checks.yaml Outdated
Comment thread .github/workflows/run_markdown_code_checks.yaml Outdated
coderabbitai[bot]
coderabbitai Bot previously approved these changes Feb 4, 2026
chrisaddy
chrisaddy previously approved these changes Feb 4, 2026
@forstmeier forstmeier force-pushed the address-dependabot-security-alerts branch from 8c0d424 to 1fb422d Compare February 4, 2026 19:22
Base automatically changed from address-dependabot-security-alerts to master February 4, 2026 19:34
@forstmeier forstmeier dismissed stale reviews from chrisaddy and coderabbitai[bot] February 4, 2026 19:34

The base branch was changed.

forstmeier and others added 2 commits February 4, 2026 14:34
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@forstmeier forstmeier force-pushed the expand-and-update-github-code-check-workflows branch from 5c6f34d to 821e0ac Compare February 4, 2026 19:35
coderabbitai[bot]
coderabbitai Bot previously approved these changes Feb 4, 2026
Copilot AI review requested due to automatic review settings February 4, 2026 20:07
@forstmeier forstmeier force-pushed the expand-and-update-github-code-check-workflows branch from 821e0ac to c1aba8b Compare February 4, 2026 20:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/run_python_code_checks.yaml Outdated
@graphite-app graphite-app Bot requested a review from chrisaddy February 4, 2026 20:08
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread .github/workflows/run_python_code_checks.yaml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/run_rust_code_checks.yaml:
- Around line 14-15: Replace the floating tag for the GitHub Action usage of
dorny/paths-filter (the line containing "uses: dorny/paths-filter@v3" and the
step id "filter") with the pinned commit SHA; change the version specifier from
"@v3" to "@de90cc6fb38fc0963ad72b210f1f284cd68cea36" so the workflow uses the
exact release (v3.0.2) instead of a moving tag.

Comment thread .github/workflows/run_rust_code_checks.yaml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @.github/workflows/run_markdown_code_checks.yaml:
- Around line 15-16: Replace the floating tag for the third-party GitHub Action
to pin it to the provided commit SHA: change the usage string
"dorny/paths-filter@v3" (the step with id "filter") to
"dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36" so the workflow
uses the exact commit (v3.0.2) instead of the floating `@v3` tag.

In @.github/workflows/run_python_code_checks.yaml:
- Around line 15-16: The workflow currently references the third-party action
using a floating tag at the 'uses' line (dorny/paths-filter@v3 with id
'filter'); update that 'uses' entry to pin the action to the specific commit SHA
de90cc6fb38fc0963ad72b210f1f284cd68cea36 (v3.0.2) to remove supply-chain risk
and ensure reproducible runs.

Comment thread .github/workflows/run_markdown_code_checks.yaml
Comment thread .github/workflows/run_python_code_checks.yaml
@forstmeier forstmeier merged commit 45af2bb into master Feb 4, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Overview Feb 4, 2026
@forstmeier forstmeier deleted the expand-and-update-github-code-check-workflows branch February 4, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

markdown Markdown code updates

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants