-
Notifications
You must be signed in to change notification settings - Fork 10
fix issues with datamanager and added to infrastructure #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f82a20b
fix issues with datamanager and added to infrastructure
chrisaddy 20fa0f2
Merge branch 'master' into datamanager-fixes
chrisaddy 43cf7b9
prep data for training
chrisaddy 071e83e
Merge branch 'master' into data-prep
chrisaddy 91ce978
Merge branch 'datamanager-fixes' into data-prep
chrisaddy 5d07f04
Update tools/sync_equity_bars_data.py
chrisaddy 3d64d98
Update applications/datamanager/Dockerfile
chrisaddy e875855
work on suggestions
chrisaddy c23dc19
fixes
chrisaddy c1b16a6
fixes
chrisaddy 28e450f
fixes
chrisaddy e735086
PR fixes
chrisaddy 30dc709
Merge branch 'datamanager-fixes' into data-prep
chrisaddy 19e2bbf
Merge pull request #667 from pocketsizefund/data-prep
chrisaddy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,35 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(cat:*)", | ||
| "Bash(curl:*)", | ||
| "Bash(docker:*)", | ||
| "Bash(flox activate:*)", | ||
| "Bash(gh issue:*)", | ||
| "Bash(mask:*)", | ||
| "Bash(mkdir:*)", | ||
| "Bash(pre-commit:*)", | ||
| "Bash(pulumi:*)", | ||
| "Bash(rm:*)", | ||
| "Bash(timeout 5 curl -I http://localhost:*)", | ||
| "Bash(uv:*)", | ||
| "WebFetch(domain:docs.github.com)", | ||
| "WebSearch" | ||
| ], | ||
| "deny": [], | ||
| "defaultMode": "acceptEdits" | ||
| }, | ||
| "enableAllProjectMcpServers": false | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(cat:*)", | ||
| "Bash(curl:*)", | ||
| "Bash(docker:*)", | ||
| "Bash(flox activate:*)", | ||
| "Bash(gh issue:*)", | ||
| "Bash(mask:*)", | ||
| "Bash(mkdir:*)", | ||
| "Bash(pre-commit:*)", | ||
| "Bash(pulumi:*)", | ||
| "Bash(rm:*)", | ||
| "Bash(timeout 5 curl -I http://localhost:*)", | ||
| "Bash(uv:*)", | ||
| "WebFetch(domain:docs.github.com)", | ||
| "WebSearch", | ||
| "Bash(aws ecr describe-repositories:*)", | ||
| "Bash(aws ecs describe-services:*)", | ||
| "Bash(aws logs tail:*)", | ||
| "Bash(aws logs:*)", | ||
| "Bash(xargs:*)", | ||
| "Bash(aws ecs describe-task-definition:*)", | ||
| "Bash(aws s3 cp:*)", | ||
| "Bash(python3:*)", | ||
| "Bash(aws s3 ls:*)", | ||
| "Bash(find:*)", | ||
| "Bash(gh api:*)", | ||
| "Bash(gh pr view:*)" | ||
| ], | ||
| "deny": [], | ||
| "defaultMode": "acceptEdits" | ||
| }, | ||
| "enableAllProjectMcpServers": false | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3269,4 +3269,4 @@ | |
| "priority": 5 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict broad execution permissions (python3/xargs) to least privilege.
Line 22 and Line 25 add
Bash(xargs:*)andBash(python3:*), which effectively permit arbitrary code execution and command chaining. If this file is shared in-repo, it weakens the permission boundary. Consider removing these entries or narrowing them to vetted scripts/flags.🔧 Suggested tightening (remove the broad entries unless strictly required)
📝 Committable suggestion
🤖 Prompt for AI Agents