Skip to content

add secrets to cluster#614

Merged
chrisaddy merged 1 commit into08-14-docker_swarmfrom
08-14-add_secrets_to_cluster
Aug 16, 2025
Merged

add secrets to cluster#614
chrisaddy merged 1 commit into08-14-docker_swarmfrom
08-14-add_secrets_to_cluster

Conversation

@chrisaddy
Copy link
Copy Markdown
Collaborator

@chrisaddy chrisaddy commented Aug 15, 2025

Overview

Added external secrets configuration to the Docker Compose stack file for secure credential management.

Changes

  • Added secrets section with external secrets for:
    • Alpaca API credentials (key, secret, base URL)
    • Edgar user agent
    • Data bucket configuration
    • Polygon API key
    • DuckDB credentials (access key, secret)
    • Grafana admin password
    • Weights and Biases API key
  • Removed unnecessary comment in services section

Comments

These external secrets will be used by various services in the stack to securely access APIs and data sources without hardcoding credentials in the configuration files.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 08-14-add_secrets_to_cluster

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chrisaddy chrisaddy mentioned this pull request Aug 15, 2025
@chrisaddy chrisaddy marked this pull request as ready for review August 15, 2025 03:58
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Aug 15, 2025

Graphite Automations

"Assign author to pull request" took an action on this PR • (08/15/25)

1 assignee was added to this PR based on John Forstmeier's automation.

Copy link
Copy Markdown
Collaborator

@forstmeier forstmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine we'll just need to unify environment variable naming as PRs go in but that's easy.

@chrisaddy chrisaddy merged commit d075629 into 08-14-docker_swarm Aug 16, 2025
3 of 4 checks passed
@chrisaddy chrisaddy deleted the 08-14-add_secrets_to_cluster branch August 16, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants