Rename workflow files and add datamanager deployment workflows#600
Rename workflow files and add datamanager deployment workflows#600forstmeier wants to merge 1 commit intomasterfrom
Conversation
WalkthroughThis change restructures GitHub Actions workflows for infrastructure and application lifecycle management. It deletes the combined scheduled lifecycle workflow and the deploy workflow, introduces separate scheduled workflows for launching and tearing down both the application and datamanager services, and makes minor job name updates in code quality and test workflows. Changes
Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant GitHub Actions
participant Flox
participant Pulumi
Scheduler->>GitHub Actions: Trigger (scheduled or manual)
GitHub Actions->>GitHub Actions: Time/Day Check (if needed)
GitHub Actions->>GitHub Actions: Checkout Code
GitHub Actions->>Flox: Install Flox
GitHub Actions->>Flox: Activate Environment
GitHub Actions->>Pulumi: Run pulumi up/down (deploy/teardown)
Pulumi-->>GitHub Actions: Result
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR renames existing workflow files and introduces new workflows for deploying and tearing down the datamanager service. Key changes include the addition of new datamanager deployment and teardown workflows, an update to the scheduled application management workflow naming, and the removal of the legacy deploy workflow.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/teardown_datamanager.yaml | New workflow for scheduled teardown of the datamanager service |
| .github/workflows/deploy_datamanager.yaml | New workflow for manual deployment of the datamanager service |
| .github/workflows/deploy_and_teardown_application.yaml | Renamed and updated to manage application scheduling with improved job names |
| .github/workflows/deploy.yaml | Removed legacy deploy workflow |
Graphite Automations"Assign author to pull request" took an action on this PR • (06/17/25)1 assignee was added to this PR based on John Forstmeier's automation. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
.github/workflows/teardown_datamanager.yaml (2)
17-17: Remove trailing whitespace.
YAMLlint flagged trailing spaces on line 17. Please delete the unnecessary spaces to comply with linting rules.
39-39: Ensure newline at end of file.
Add a newline after the last line to satisfy thenew-line-at-end-of-filelint rule..github/workflows/deploy_datamanager.yaml (1)
21-21: Ensure newline at end of file.
Add a trailing newline to satisfy thenew-line-at-end-of-filelint rule.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/deploy.yaml(0 hunks).github/workflows/deploy_and_teardown_application.yaml(2 hunks).github/workflows/deploy_datamanager.yaml(1 hunks).github/workflows/teardown_datamanager.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/deploy.yaml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/deploy_datamanager.yaml
[error] 21-21: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/teardown_datamanager.yaml
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 39-39: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run Python tests
🔇 Additional comments (2)
.github/workflows/deploy_datamanager.yaml (1)
1-3: Workflow trigger and steps look correct.
Theworkflow_dispatchtrigger and Pulumi/Flox steps are well-configured for manual datamanager deployments..github/workflows/deploy_and_teardown_application.yaml (1)
25-26: ```shell
#!/bin/bashCheck for Flox configuration files in the repo root
echo "Searching for Flox configuration files..."
config_files=$(ls flox.toml flox.yaml floxfile.* 2>/dev/null || true)
if [ -n "$config_files" ]; then
echo "Found Flox configuration file(s):"
echo "$config_files"
echo "Displaying contents of the first file:"
head -n 200 $(echo "$config_files" | head -n1)
else
echo "No Flox configuration file (flox.toml, flox.yaml, or floxfile.*) found"
fi</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
forstmeier
force-pushed
the
06-16-rename_workflow_files_and_add_datamanager_deployment_workflows
branch
from
3c89f47 to
3235ee6
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/deploy_datamanager.yaml (1)
21-21: Add missing newline at end of file
YAMLlint reports no newline at EOF. Please append a blank line after the last command to satisfy the new-line-at-end-of-file rule..github/workflows/teardown_datamanager.yaml (2)
17-17: Remove trailing spaces
Line 17 contains unnecessary trailing whitespace. Please delete the extra spaces to clean up the shell script block.
39-39: Add missing newline at end of file
YAMLlint flags a missing newline at EOF. Append a blank line after the finalpulumi destroystep to comply with YAML conventions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/deploy.yaml(0 hunks).github/workflows/deploy_and_teardown_application.yaml(2 hunks).github/workflows/deploy_datamanager.yaml(1 hunks).github/workflows/teardown_datamanager.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/deploy.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/deploy_and_teardown_application.yaml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/deploy_datamanager.yaml
[error] 21-21: no new line character at the end of file
(new-line-at-end-of-file)
.github/workflows/teardown_datamanager.yaml
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 39-39: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run Python tests
forstmeier
force-pushed
the
06-16-rename_workflow_files_and_add_datamanager_deployment_workflows
branch
from
3235ee6 to
037e9bc
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/teardown_datamanager.yaml (3)
17-17: Remove trailing whitespace
There's trailing spaces on this blank line (17) which will trigger lint errors. Please delete them.
12-24: Consider extracting market-hours check into a composite action
This “Check if within market hours” logic appears in multiple workflows. Packaging it as a reusable composite action would DRY up the pipelines and centralize maintenance.
39-39: Add terminating newline
POSIX-compliant files should end with a newline to avoid warnings in various tools.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.github/workflows/check_code_quality.yaml(1 hunks).github/workflows/close_stale_issues_and_pull_requests.yaml(1 hunks).github/workflows/deploy.yaml(0 hunks).github/workflows/launch_application.yaml(1 hunks).github/workflows/launch_datamanager.yaml(1 hunks).github/workflows/lifecycle.yaml(0 hunks).github/workflows/run_tests.yaml(1 hunks).github/workflows/teardown_application.yaml(1 hunks).github/workflows/teardown_datamanager.yaml(1 hunks)
💤 Files with no reviewable changes (2)
- .github/workflows/deploy.yaml
- .github/workflows/lifecycle.yaml
✅ Files skipped from review due to trivial changes (6)
- .github/workflows/check_code_quality.yaml
- .github/workflows/run_tests.yaml
- .github/workflows/close_stale_issues_and_pull_requests.yaml
- .github/workflows/teardown_application.yaml
- .github/workflows/launch_datamanager.yaml
- .github/workflows/launch_application.yaml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/teardown_datamanager.yaml
[error] 17-17: trailing spaces
(trailing-spaces)
[error] 39-39: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run Python tests
🔇 Additional comments (1)
.github/workflows/teardown_datamanager.yaml (1)
20-21: Explicit base-10 conversion is correct
The use of10#$current_timeprevents unintended octal parsing of leading-zero timestamps.
|
Marked stale due to inactivity. Remove stale label or comment or this will be closed. |
|
Closed due to inactivity. |
forstmeier
deleted the
06-16-rename_workflow_files_and_add_datamanager_deployment_workflows
branch
Overview
Changes
datamanagerservice deployment workflowsComments
I was thinking we'll want a way to have
datamanageravailable outside market hours for model training so this is a stab at that. Open to other ideas.Summary by CodeRabbit
New Features
Chores