Skip to content

Fixes from coderabbit #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisaddy merged 4 commits into from
May 28, 2025
Merged

Fixes from coderabbit #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86f06bd
Update application/positionmanager/src/positionmanager/clients.py
chrisaddy May 28, 2025
a2f1f12
fixes from coderabbit
chrisaddy May 28, 2025
dd2c3ea
fixes from code rabbit
chrisaddy May 28, 2025
7e2f75a
Merge branch 'introduce-ty' into fixes-from-coderabbit
chrisaddy May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions application/datamanager/src/datamanager/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ def daily_bars_path(self) -> str:
raise ValueError("DATA_BUCKET environment variable is required")
return f"gs://{self.name}/equity/bars/"

@computed_field
def daily_bars_path(self) -> str:
return f"gs://{self.name}/equity/bars/"


class GCP(BaseModel):
bucket: Bucket = Bucket()
Expand Down
10 changes: 2 additions & 8 deletions application/positionmanager/src/positionmanager/clients.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,8 @@
class AlpacaClient:
def __init__(
self,
def __init__(
- api_key: str | None = "",
- api_secret: str | None = "",
+ api_key: str | None = None,
+ api_secret: str | None = None,
paper: bool = True,
) -> None:
# ...
api_key: str | None = None,
api_secret: str | None = None,
paper: bool = True,
) -> None:
if not api_key or not api_secret:
Expand Down