Skip to content

fix pulumi secret#561

Merged
chrisaddy merged 1 commit intomasterfrom
fix-pulumi-action
May 28, 2025
Merged

fix pulumi secret#561
chrisaddy merged 1 commit intomasterfrom
fix-pulumi-action

Conversation

@chrisaddy
Copy link
Copy Markdown
Collaborator

@chrisaddy chrisaddy commented May 26, 2025

This pull request updates the deployment workflow to streamline the configuration and improve compatibility with the Pulumi environment. The most important changes are as follows:

Workflow configuration updates:

Command simplification:

  • .github/workflows/deploy.yaml: Updated the command property in the deploy job to use mise run infrastructure:up instead of mise tasks run infrastructure:up, simplifying the command syntax.

Summary by CodeRabbit

  • Chores
    • Updated deployment workflow to specify the "pulumi" environment and simplified the deployment command.

@chrisaddy chrisaddy requested a review from forstmeier May 26, 2025 18:41
@chrisaddy chrisaddy self-assigned this May 26, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2025

Walkthrough

The deployment workflow configuration was updated to specify a "pulumi" environment for the deploy job and to simplify the deployment command from mise tasks run infrastructure:up to mise run infrastructure:up. No changes were made to exported or public entities.

Changes

File(s) Change Summary
.github/workflows/deploy.yaml Added "pulumi" environment to deploy job; updated deployment command syntax.

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • forstmeier

Poem

The workflow hops with nimble feet,
Now "pulumi" is where it’ll meet.
A simpler command, a cleaner run,
Deployment’s journey has begun!
With YAML neat and changes small,
The rabbit cheers, “Good work, you all!” 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56b85ab and 409f6d9.

📒 Files selected for processing (1)
  • .github/workflows/deploy.yaml (2 hunks)
🔇 Additional comments (2)
.github/workflows/deploy.yaml (2)

11-11: Verify that the pulumi environment is configured in GitHub
The new environment: pulumi property will route deploys through that environment’s protection rules and secrets. Please confirm you have created an environment named pulumi in your repository settings and that it has the necessary PULUMI_ACCESS_TOKEN secret (or that it falls back correctly to the repo‐level secret).


22-22:

Details

✅ Verification successful

Ensure no residual references to the old command remain
You’ve simplified the step command to mise run infrastructure:up. Let’s verify we didn’t leave behind any occurrences of the previous mise tasks run infrastructure:up.


🏁 Script executed:

#!/usr/bin/env bash
# Check for any leftover references to the old Pulumi invocation
rg -R "mise tasks run infrastructure:up"

Length of output: 447


🏁 Script executed:

#!/usr/bin/env bash
# Correctly search the entire repo for any leftover references to the old Pulumi invocation
rg -F "mise tasks run infrastructure:up"

Length of output: 42


No residual references to the old command remain
I ran rg -F "mise tasks run infrastructure:up" across the entire repository and found no matches—everything’s been updated to mise run infrastructure:up.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chrisaddy chrisaddy merged commit 748f753 into master May 28, 2025
5 checks passed
@chrisaddy chrisaddy deleted the fix-pulumi-action branch May 28, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants