Conversation
fixing gh actions
fixing gh actions
Delete CNAME update Aeson parser tidy nitpicks
WalkthroughThis change removes all Haskell-based "platform" application source code, configuration, and build artifacts, including Docker and Compose files, and test suites. Project configuration files are updated to eliminate Haskell and platform-related entries, refocusing build and task automation on Python workflows and dynamic application service management. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Mise as Mise Task Runner
participant Docker as Docker Engine
Dev->>Mise: Run application:service:build <service>
Mise->>Docker: Build Docker image for <service> (dynamic path/tag)
Docker-->>Mise: Image built
Dev->>Mise: Run application:service:run <service>
Mise->>Docker: Run container for <service> with env/ports
Docker-->>Mise: Service running
Possibly related PRs
Suggested labels
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Graphite Automations"Assign author to pull request" took an action on this PR • (05/13/25)1 assignee was added to this PR based on John Forstmeier's automation. |
chrisaddy
force-pushed
the
infrastructure
branch
8 times, most recently
from
e4ceaa8 to
ff72dc8
Compare
cleanups
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.mise.toml (1)
59-66: Parameterize port mapping for service run
Theapplication:service:runtask hardcodes port8080:8080. If services listen on different ports or require multiple mappings, consider adding a configurableportargument or using{{arg(...)}}for flexibility.
🛑 Comments failed to post (1)
.mise.toml (1)
28-45:
⚠️ Potential issueFix missing closing triple-quote in Python test task
Therunblock forpython:teststarts with"""but lacks a matching closing""", causing a TOML syntax error. Add the closing triple-quote after the last command:... uv run coverage xml \ --data-file .python_coverage.output \ -o .python_coverage.xml + """📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.[tasks."python:test"] description = "Run Python tests" run = """ uv run coverage run \ --parallel-mode \ --omit '*/__init__.py,**/test_*.py' \ --data-file .python_coverage.output \ --module pytest uv run coverage combine \ --data-file .python_coverage.output uv run coverage report \ --data-file .python_coverage.output uv run coverage xml \ --data-file .python_coverage.output \ -o .python_coverage.xml """
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.mise.toml (3)
1-3: Ensure Python tasks include installation dependency.
The newpython:installtask correctly installs dependencies, but downstream Python tasks (format,dead-code,lint) should explicitly depend on it to guarantee the environment is prepared before execution.Consider adding:
[tasks."python:format"] +depends = ["python:install"] ... [tasks."python:dead-code"] +depends = ["python:install"] ... [tasks."python:lint"] +depends = ["python:install"] ...
28-46: Add dependency on linting before tests.
Thepython:testtask should depend onpython:lintto ensure code quality checks run prior to test execution. Otherwise, tests may run against unformatted or unchecked code, and missing dependencies could cause failures.[tasks."python:test"] +depends = ["python:lint"] description = "Run Python tests" run = """ uv run coverage run \ --parallel-mode \ --omit '*/__init__.py,**/test_*.py' \ --data-file .python_coverage.output \ --module pytest uv run coverage combine \ --data-file .python_coverage.output uv run coverage report \ --data-file .python_coverage.output uv run coverage xml \ --data-file .python_coverage.output \ -o .python_coverage.xml """
59-66: Run services in detached mode.
Adding-dto thedocker runcommand will allow containers to run in the background, enabling non-blocking workflows and easier management of multiple services.[tasks."application:service:run"] run = """ docker run \ + -d \ --env-file .env \ --publish 8080:8080 \ pocketsizefund/{{arg(name="service_name")}}:latest \ """
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
platform/stack.yaml.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
.flox/env/manifest.toml(1 hunks).gitignore(0 hunks).mise.toml(2 hunks)README.md(2 hunks)platform/Dockerfile(0 hunks)platform/Setup.hs(0 hunks)platform/app/Main.hs(0 hunks)platform/compose.yaml(0 hunks)platform/package.yaml(0 hunks)platform/platform.cabal(0 hunks)platform/src/Account.hs(0 hunks)platform/src/Lib.hs(0 hunks)platform/stack.yaml(0 hunks)platform/test/Spec.hs(0 hunks)
💤 Files with no reviewable changes (11)
- platform/stack.yaml
- platform/compose.yaml
- platform/app/Main.hs
- .gitignore
- platform/Dockerfile
- platform/src/Lib.hs
- platform/src/Account.hs
- platform/package.yaml
- platform/Setup.hs
- platform/test/Spec.hs
- platform/platform.cabal
✅ Files skipped from review due to trivial changes (1)
- README.md
🚧 Files skipped from review as they are similar to previous changes (1)
- .flox/env/manifest.toml
🔇 Additional comments (4)
.mise.toml (4)
6-6: Skipping trivial description update.
11-11: Skipping trivial description update.
21-21: Skipping trivial description update.
48-57: Dynamic Docker build task looks solid.
The parameterizedapplication:service:buildcorrectly builds images with bothlatestand timestamp tags. Usage of{{arg(name="service_name")}}is clear and replaces the removed Haskell-specific tasks appropriately.
2 participants
This pull request introduces several changes across the codebase, including updates to workflows, task definitions, and configuration files, as well as the removal of Haskell-related files and functionality. The most significant changes are grouped below by theme.
Workflow Automation and CI/CD Enhancements:
.github/workflows/format.yaml) to check code formatting and linting usingmise. This ensures code quality is maintained in pull requests..github/workflows/test.yaml) where the test command was incorrectly written asmise run tesetinstead ofmise run test.Task Definitions and Tooling Updates:
.mise.tomlto add apython:checktask for running Python code quality checks and restructured task dependencies. Introduced a newhaskell:buildtask for building Haskell code. [1] [2]Haskell Code and Configuration Removal:
platform/Dockerfile,platform/Setup.hs,platform/app/Main.hs, andplatform/src/Lib.hs, effectively deprecating the Haskell-based platform functionality. [1] [2] [3] [4]platform/package.yamlandplatform/platform.cabal, removing Haskell package configurations. [1] [2]Configuration and Dependency Management:
.flox/env/manifest.tomlby removing unused dependencies and sections, streamlining the environment configuration.Miscellaneous Additions:
.python_coverage.xmlfile to track Python code coverage metrics.infrastructure/.claude/settings.local.json) for specific commands to enhance security.These changes collectively improve workflow automation, simplify task management, and remove deprecated functionality, aligning the project with updated requirements and best practices.
Summary by CodeRabbit
.DS_Storefiles in version control.