Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tmp] Allow call cargo build directly, multiple bin compilation #21

Open
Kerollmops opened this issue Mar 27, 2016 · 10 comments · May be fixed by #35
Open

[tmp] Allow call cargo build directly, multiple bin compilation #21

Kerollmops opened this issue Mar 27, 2016 · 10 comments · May be fixed by #35

Comments

@Kerollmops
Copy link

A temporary fix to the cargo check multiple binary problem related to this sublimelinter-contrib-rust issue can be to allow the user to call directly the cargo build command which will don't ask to specify --bin NAME parameter to compile everything and return all errors/warnings.

_Temporary_ 😄

@Kerollmops Kerollmops changed the title Allow call cargo build directly, multiple bin compilation [tmp] Allow call cargo build directly, multiple bin compilation Mar 27, 2016
@Kerollmops
Copy link
Author

https://github.com/Kerosene2000/SublimeLinter-contrib-rustc/commit/0caf73599da7a5ea7f3bb30d3446fe909b3128a2
It's working great! But it will be very slow to compile the binaries each time you want to check only the syntax 😢

@vadixidav
Copy link

I filed an issue on the fork of cargo-check called cargo-clippy where activity seems to be much more common. It might be worth considering switching.

@Manishearth
Copy link

cargo check and cargo clippy are different things, not forks.

@llogiq
Copy link

llogiq commented May 16, 2016

To elaborate, cargo check only parses and type-checks the code,whereas cargo clippy runs a battery of lints (which is slower but will find more things worthy of improvement).

@vadixidav
Copy link

Ahh, I thought it was a fork for some reason. Cargo check still hasn't seen
nearly as much activity (only 8 commits).
On May 16, 2016 11:08 AM, "llogiq" [email protected] wrote:

To elaborate, cargo check only parses and type-checks the code,whereas cargo
clippy runs a battery of lints (which is slower but will find more things
worthy of improvement).


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#21 (comment)

@Manishearth
Copy link

cargo check does a very simple thing, so there's no need for more activity

@Kerollmops
Copy link
Author

Kerollmops commented May 16, 2016

I think cargo check needs to be capable to check multiple bin/libs.
cargo build can do that, why not cargo check ?

@Manishearth
Copy link

cargo build doesn't build all bins at once, IIRC

@Manishearth
Copy link

Anyway, both cargo check and cargo clippy forward to cargo rustc, a built-in subcommand, which is the one which doesn't allow stuff to be run on all targets. The bug should be on cargo

@Kerollmops
Copy link
Author

Kerollmops commented May 16, 2016

No, but it checks the syntax and then compile each binary/library, why cargo check cannot just check syntax ?
Yes, that's right, cargo rustc is the problem source !

@FichteFoll FichteFoll linked a pull request Dec 2, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants