Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for using a custom TimeZone #1

Closed
oscarmcm opened this issue Aug 9, 2022 · 1 comment · Fixed by #8
Closed

Support for using a custom TimeZone #1

oscarmcm opened this issue Aug 9, 2022 · 1 comment · Fixed by #8
Assignees
@oscarmcm
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@oscarmcm
Copy link
Owner

oscarmcm commented Aug 9, 2022 •
edited
Loading

Following the same logic in #7 we can add support for timezone configuration via the timeZone parameter, we can also support this in the config.ini file
@oscarmcm oscarmcm added the enhancement New feature or request label Aug 9, 2022
@oscarmcm oscarmcm self-assigned this Aug 9, 2022
@oscarmcm oscarmcm added this to the 1.0.0 milestone Aug 9, 2022
@oscarmcm
Copy link
Owner Author

oscarmcm commented Aug 9, 2022

The order of importance for the timezone is as follows

  • (1) As CLI argument:
neocal --timezone America/Los_Angeles
  • (2) As Key-Value in the calendar section config:
[work]
endpoint = <URL>
timezone = America/Los_Angeles
  • (3) As Key-Value in the neocal section config:
[neocal]
default = work
timezone = America/Los_Angeles

oscarmcm added a commit that referenced this issue Aug 9, 2022
@oscarmcm
Add support for set timezone - Refs #1
2798ff0 
Now we can return the events in a specific timezone format as follows:

- via cli argument
	neocal --timezone America/Los_Angeles
- via calendar config
	[work]
	endpoint = <URL>
	timezone = America/Los_Angeles
- via neocal config
	[neocal]
	default = work
	timezone = America/Los_Angeles
@oscarmcm oscarmcm mentioned this issue Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscarmcm oscarmcm

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Add support for timezone filter oscarmcm/neocal
1 participant
@oscarmcm