add facstd (#858) #859
add facstd (#858) #859
Conversation
|
@hannes14 what's the status of this? If this should be merged then I'd advise to re-run tests (e.g. by rebasing this PR and force pushing or by just closing and immediately reopening this PR), and then someone from geometry group should merge it (possibly you yourself but of course if someone else like @ederc could review it, the better) |
|
This PR is fine for me, let's rerun the checks. |
|
Precompiling Singular.jl with julia 1.6.7 fails with: |
|
The conflicting GLIBCXX_3.4.32 comes from libsingular_julia which is reused und - as it seems- with a newer system |
|
@hannes14 let's also get this merged, assuming CI passes now... |
|
(Besides before updating |
src/ideal/ideal.jl
Outdated
| GC.@preserve I R libSingular.stdfac(I.ptr, a, R.ptr) | ||
| b=Vector{sideal{spoly{T}}}() | ||
| for i in 1:size(a)[1] | ||
| push!(b,sideal{spoly{T}}(R,reinterpret(libSingular.ideal_ptr,a[i]),true)) |
There was a problem hiding this comment.
This line triggers an error in Julia 1.6:
sideal.facstd: Error During Test at /home/runner/work/Singular.jl/Singular.jl/test/ideal/sideal-test.jl:742
Got exception outside of a @test
bitcast: target type not a leaf primitive type
Stacktrace:
[1] reinterpret
@ ./essentials.jl:422 [inlined]
[2] facstd(I::sideal{spoly{n_Q}})
@ Singular ~/work/Singular.jl/Singular.jl/src/ideal/ideal.jl:1568
...
4 participants
No description provided.