Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 74.66% 74.58% -0.09%
==========================================
Files 55 55
Lines 4713 4713
==========================================
- Hits 3519 3515 -4
- Misses 1194 1198 +4
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
lgoettgens
reviewed
Jan 11, 2025
CHANGES.md
Outdated
| # Changes in GAP.jl | ||
|
|
||
| ## Version 0.13.0-DEV (released YYYY-MM-DD) | ||
| ## Version 0.13.0 (released 2025-01-09) |
Member
There was a problem hiding this comment.
Reminder: Date needs to be updated again
lgoettgens
reviewed
Jan 11, 2025
lgoettgens
approved these changes
Jan 11, 2025
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
Apart from the release date this looks good to me. The OscarCI with the current GAP.jl master is happy as well (cf https://github.com/oscar-system/Oscar.jl/actions/runs/12725036717?pr=4421)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1114