otk: don't use click #102
Merged
otk: don't use click #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supakeen
force-pushed
the
use-argparse
branch
5 times, most recently
from
5fe3419
to
2a6fcd1
Compare
|
This PR also drops the |
achilleas-k
requested changes
May 30, 2024
Don't use click as it is not available in RHEL, instead use the built-in argparse. This also adds minor tests for the command line. Signed-off-by: Simon de Vlieger <[email protected]>
These examples accidentally got into the repository. Signed-off-by: Simon de Vlieger <[email protected]>
Use the argparse required subcommands even if the help is a bit suboptimal it gives us clearer code. Signed-off-by: Simon de Vlieger <[email protected]>
We need this available earlier otherwise the next check fails. Signed-off-by: Simon de Vlieger <[email protected]>
Doing this makes the output show the place where the subcommand goes. Signed-off-by: Simon de Vlieger <[email protected]>
This can live in the constructor. Signed-off-by: Simon de Vlieger <[email protected]>
Setting the help makes sure the command actually show up in the help text. Signed-off-by: Simon de Vlieger <[email protected]>
achilleas-k
reviewed
May 30, 2024
| log.info("Compiling the input file %r to %r", input, output or "STDOUT") | ||
| if not src.exists(): | ||
| log.fatal("INPUT path %r does not exist", str(src)) | ||
| return 1 |
There was a problem hiding this comment.
Function's type annotation should say it returns an int now.
There was a problem hiding this comment.
Added a commit to fix the signature.
Signed-off-by: Simon de Vlieger <[email protected]>
achilleas-k
approved these changes
May 30, 2024
mvo5
added a commit
to mvo5/osbuild-otk
that referenced
this pull request
Jun 21, 2024
Click was removed in osbuild#102 so it can be safely removed from the pyproject.toml.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
Click was removed in #102 so it can be safely removed from the pyproject.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start removing click from the main otk command.