Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-manifests: derive seedArg from filename and env #664

Closed
wants to merge 1 commit into from

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented May 6, 2024

To ensure that manifests get random(ish) and stable UUIDs we set the rng seed arg based on the filename.

This should fix the issue discovered in
osbuild/manifest-db#124

that duplicated UUIDs for xfs/btrfs can trigger random(ish) and hard to diagnose errors.

This is the same as
osbuild/osbuild-composer#4124 hopefully for the right place this time.

@mvo5 mvo5 requested a review from achilleas-k May 6, 2024 09:27
@achilleas-k achilleas-k changed the title gen-manifests: derrive seedArg from filename and env gen-manifests: derive seedArg from filename and env May 6, 2024
@achilleas-k
Copy link
Member

We should also do the same in cmd/build for consistency (see also #88).

@mvo5
Copy link
Contributor Author

mvo5 commented May 8, 2024

We should also do the same in cmd/build for consistency (see also #88).

Thank you! I wasn't aware of this - I reworked this in #674 now

To ensure that manifests get random(ish) and stable UUIDs we set
the rng seed arg based on the filename.

This should fix the issue discovered in
osbuild/manifest-db#124

that duplicated UUIDs for xfs/btrfs can trigger random(ish) and
hard to diagnose errors.

This is the same as
osbuild/osbuild-composer#4124
hopefully for the right place this time.
@mvo5
Copy link
Contributor Author

mvo5 commented May 14, 2024

Closing in favor of #674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants