osbuild: extract genMountsDevicesFromPt helper
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `org.osbuild.copy` stage requires mounts/devices options when run. Those will also be required by the coming `bootupd` stage. To prepare for this the helper is extracted and tests added.
Both the osbuild and the image package need/will need a helper to make fake partition tables. So this creates a new `testdisk` package that contains a helper for this. It can not be part of the existing `test` package because of circular imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
org.osbuild.copystage requires mounts/devices options whenrun. Those will also be required by the coming
bootupdstage.To prepare for this the helper is extracted and tests added.
There is a second commit that extracts a common
testdisk.MakeFakePartitionTable("/", "/boot")helper which is not strictly needed but feels nicer.This is the first split out of #381