Fix ostree deployment target #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we haven't been passed an ostree remote, don't use it for verification; just use `ostree-unverified-image` which matches containers/bootc@20d2d6c
This will address osbuild/bootc-image-builder#69 (But not marking closes because we need to update the vendor there)
runcom
reviewed
Jan 17, 2024
There was a problem hiding this comment.
lgtm - I'll leave it to @ondrejbudai to verify given the bug report
|
Thanks! Doing a quick local test to verify before approving and merging. |
achilleas-k
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ostree: Fix target imgref
If we haven't been passed an ostree remote, don't use it for
verification; just use
ostree-unverified-imagewhich matchescontainers/bootc@20d2d6c
ostree: Use local name when creating deployment
This will address osbuild/bootc-image-builder#69
(But not marking closes because we need to update the vendor there)