image,manifest: allow using the qcow2 pipeline without a build pipeline (HMS-3318) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to use the qcow2 pipeline outside of a build pipeline. The use-case is the `bootc-image-builder` that will use arbitrary containers as buildroots and we cannot assume that they have `qemu-util` installed. And because `bootc-image-builder` is already a container we can install `qemu-util` there and be confident that it will work.
mvo5
force-pushed
the
image/qcow2-from-bib
branch
from
03df395
to
1b61566
Compare
mvo5
changed the title
Not a problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows to use the qcow2 pipeline outside of a build pipeline. The use-case is the
bootc-image-builderthat will use arbitrary containers as buildroots and we cannot assume that they haveqemu-utilinstalled. And becausebootc-image-builderis already a container we can installqemu-utilthere and be confident that it will work.Note that there is one small drive-by one-ine improvement in one of the panics()s. I had a bit of trouble writing the test and this helped me to pinpoint what is missing. Happy to remove it again (as it's not needed for the PR itself).