Print more informational branch info for previous builds #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a manifest has already been built, we would assume it was on a PR and print a link to the PR in the info message. But new manifests can also appear on the merge queue (from the rebase) so let's handle that case too. We can't link to it directly because the merge queue branch is deleted after it's merged, but the commit ID is enough info to recreate the build conditions if needed and the name of the merge queue branch includes the PR number if more context is needed. If the PR field is empty, print an appropriate message too. This shouldn't happen now, the condition was there while old info existed that is all gone now, but let's keep it in case something unexpected happens with the writing of the build info in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a manifest has already been built, we would assume it was on a PR and print a link to the PR in the info message. But new manifests can also appear on the merge queue (from the rebase) so let's handle that case too. We can't link to it directly because the merge queue branch is deleted after it's merged, but the commit ID is enough info to recreate the build conditions if needed and the name of the merge queue branch includes the PR number if more context is needed.
If the PR field is empty, print an appropriate message too. This shouldn't happen now, the condition was there while old info existed that is all gone now, but let's keep it in case something unexpected happens with the writing of the build info in the future.