Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anaconda: bios boot for container-installer #360

Merged
merged 1 commit into from
Jan 13, 2024
Merged

anaconda: bios boot for container-installer #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/manifest/anaconda_installer_iso_tree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,8 @@ keyboard us
timezone UTC

clearpart --all

part biosboot --size=1 --fstype=biosboot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should be able to use reqpart too now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking here: #362.

part /boot/efi --fstype=efi --size=512 --fsoptions="umask=0077"
part /boot --fstype=ext2 --size=1024 --label=boot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really really should not use ext2 here...there's no filesystem journaling. Is this a hack-around for osbuild/bootc-image-builder#20 ?

If so, then...we need a reminder to remove it ASAP. If it's not, please fix to use ext4.

Of course this larger topic goes really into the rampant duplication we have of the filesystem layout in kickstarts, many times in Go code in this repo, anaconda, and bootc, and fedora-coreos etc.

What I think we should aim for is moving the default partitioning into the container - not hardcoded in this repo or in bootc code. Doing that with anaconda would require rhinstaller/anaconda#5197

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed it feels icky, it was taken directly from a pre-existing kickstart which only solidifies the problem. Tracking here: #362.

part swap --fstype=swap --size=1024
Expand Down
Loading