test: compare osbuild version for image builds and don't specify boot mode #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
4 times, most recently
from
8fb290c
to
c775681
Compare
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
2 times, most recently
from
a1e588f
to
60c296a
Compare
|
Embarrassing typo fixed 😳 |
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
from
60c296a
to
e616d35
Compare
|
There were three test failures from Shutzbot, but I'm not sure I understand the failures. Looks like they built the disk images fine and uploaded them to AWS and launched instances, but something after instance launch failed?
|
|
I think the thing the failures have in common is that they're all BIOS only. I think the issue is that when we boot them we don't specify so maybe they're defaulting to UEFI in EC2. But that doesn't explain why they succeeded in the past, unless something changed with our uploader or the AWS library defaults. |
|
Oops, there it is: 15e9d28 |
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
2 times, most recently
from
8895afd
to
ec19b05
Compare
|
I'm going to clean this up (remove the osbuild PR pin) and mark it ready since I found a few issues while setting it up. |
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
from
ec19b05
to
9274200
Compare
achilleas-k
changed the title
osbuild PR osbuild/osbuild#1493 changes a small detail in the way device paths are passed into the stage. Let's start using it to catch any issues. osbuild/osbuild@dfd59a3
We want to move some of the functions into the testlib module so lets move the script there first and have it import the module.
Record the osbuild commit ID from the Schutzfile in the build info when a build is successful. If a commit ID isn't specified, record it as "RELEASE" to signify that the osbuild version is the one in the distro repos. If the osbuild version and commit ID don't match, schedule the config for a build. This makes sure that changes in osbuild which don't affect the manifest get retested. This can catch bugs that weren't caught in osbuild and is useful for testing internal osbuild functionality changes. This commit also fixes a typo in the build info.json: obuild-version -> osbuild-version
We might specify it in the future, knowing which mode each image supports, but for now let's leave it off. This reverts commit 15e9d28.
achilleas-k
force-pushed
the
test/osbuild/devpaths
branch
from
9274200
to
4f95f7e
Compare
bcl
reviewed
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally written to test builds for osbuild/osbuild#1493.
Changes: