Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostreecontainer for kickstart stage. #308

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

supakeen
Copy link
Member

@supakeen supakeen commented Dec 8, 2023

Draft PR for some CI goodness.

For consistency the type should be `LiveIMGOptions`.
Rename the current ostree options to ostree commit options as we'll be
getting more ostree-prefixed options.
The constructor is going to grow very unwieldy very quickly. Introduce
constructors for common usecases.
Adds the necessary stage options for the new `ostreecontainer` kickstart
command.
Switching to Fedora containers due to an updated musl in alpine causing
build errors in Go bindings to sqlite, see:
mattn/go-sqlite3#1164
@supakeen supakeen marked this pull request as ready for review December 8, 2023 13:22
@supakeen
Copy link
Member Author

supakeen commented Dec 8, 2023

Going to mark this as ready so I can do the next steps in a separate PR that introduces the AnacondaContainerInstaller :)

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. LGTM thanks!

@achilleas-k achilleas-k added this pull request to the merge queue Dec 8, 2023
Merged via the queue into osbuild:main with commit 4966daf Dec 8, 2023
9 checks passed
@supakeen supakeen deleted the kickstart-ostreecontainer branch December 8, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants