pkg: test that "empty" RepoConfig marshal to "empty" json #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that ``` ModuleHotfixes *bool `json:"module_hotfixes"` ``` lacked the required `omitempty` which may cause issues with dnfjson. As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing `omitempty`. Note that the `rpmmd` part is not strictly needed but it feels more correct to do the check in both places that use a repoConfig. [0] osbuild#284 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression test for an issue found during the review of PR#284 [0]. The issue was that
lacked the required
omitemptywhich may cause issues with dnfjson.As a quick and easy way to prevent this in the future this commit adds a small test that ensures that we notice any missing
omitempty.Note that the
rpmmdpart is not strictly needed but it feels more correct to do the check in both places that use a repoConfig.[0] #284 (comment)