Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository: Normalize handling of false for module_hotfixes #299

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ezr-ondrej
Copy link
Contributor

@ezr-ondrej ezr-ondrej commented Dec 4, 2023

This removes nil boolean values from Hash calculation.

@ezr-ondrej
Copy link
Contributor Author

This is just a clean-up after introducing new function in hash just for one boolean flag.
I do not know the consequences of changing Hash calculation, so happy to lear if someone knows what else needs to happen for this not to break stuff :)

This removes nil boolean values from Hash calculation.
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look ok to me, I'm always a fan of less nil :)

@ezr-ondrej
Copy link
Contributor Author

Shall I self-merge? 🦖

@ondrejbudai ondrejbudai added this pull request to the merge queue Dec 13, 2023
Merged via the queue into osbuild:main with commit 20808e9 Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants